Re: [Qemu-devel] [PATCH] cleanup of ROUND_UP-like lines

2014-07-02 Thread Hu Tao
On Tue, Jul 01, 2014 at 02:42:43PM -0600, Eric Blake wrote: > On 06/26/2014 09:50 PM, Hu Tao wrote: > > On Thu, Jun 26, 2014 at 10:55:33AM -0600, Eric Blake wrote: > >> On 06/26/2014 12:13 AM, Hu Tao wrote: > >>> We already have ROUND_UP but there are similar macros and ROUND_UP-like > >>> lines al

Re: [Qemu-devel] [PATCH] cleanup of ROUND_UP-like lines

2014-07-01 Thread Eric Blake
On 06/26/2014 09:50 PM, Hu Tao wrote: > On Thu, Jun 26, 2014 at 10:55:33AM -0600, Eric Blake wrote: >> On 06/26/2014 12:13 AM, Hu Tao wrote: >>> We already have ROUND_UP but there are similar macros and ROUND_UP-like >>> lines all around, replace them with ROUND_UP and clean up similar macros. >>>

Re: [Qemu-devel] [PATCH] cleanup of ROUND_UP-like lines

2014-06-26 Thread Hu Tao
On Thu, Jun 26, 2014 at 10:55:33AM -0600, Eric Blake wrote: > On 06/26/2014 12:13 AM, Hu Tao wrote: > > We already have ROUND_UP but there are similar macros and ROUND_UP-like > > lines all around, replace them with ROUND_UP and clean up similar macros. > > > > Signed-off-by: Hu Tao > > --- > >

Re: [Qemu-devel] [PATCH] cleanup of ROUND_UP-like lines

2014-06-26 Thread Hu Tao
On Thu, Jun 26, 2014 at 05:52:45AM -0600, Eric Blake wrote: > On 06/26/2014 12:13 AM, Hu Tao wrote: > > We already have ROUND_UP but there are similar macros and ROUND_UP-like > > lines all around, replace them with ROUND_UP and clean up similar macros. > > Not a review (yet), but a question - how

Re: [Qemu-devel] [PATCH] cleanup of ROUND_UP-like lines

2014-06-26 Thread Eric Blake
On 06/26/2014 12:13 AM, Hu Tao wrote: > We already have ROUND_UP but there are similar macros and ROUND_UP-like > lines all around, replace them with ROUND_UP and clean up similar macros. > > Signed-off-by: Hu Tao > --- All of these conversions are correct, so: Reviewed-by: Eric Blake However,

Re: [Qemu-devel] [PATCH] cleanup of ROUND_UP-like lines

2014-06-26 Thread Eric Blake
On 06/26/2014 12:13 AM, Hu Tao wrote: > We already have ROUND_UP but there are similar macros and ROUND_UP-like > lines all around, replace them with ROUND_UP and clean up similar macros. Not a review (yet), but a question - how did you find lines to convert? Is there a particular grep pattern you

[Qemu-devel] [PATCH] cleanup of ROUND_UP-like lines

2014-06-25 Thread Hu Tao
We already have ROUND_UP but there are similar macros and ROUND_UP-like lines all around, replace them with ROUND_UP and clean up similar macros. Signed-off-by: Hu Tao --- block/qcow.c | 2 +- block/vdi.c | 2 +- block/vpc.c | 2 +- bsd-user/elfload.c | 2 +- exec