On 10/09/2016 04:33 AM, Anand J wrote:
>>> grep -r --exclude-dir=bin/ "#include" | sort | uniq -c | awk '{if ($1 >
>> 1)
>>> print $2}'
>>
>> Seems simple enough that we ought to make it part of the
>> scripts/clean-includes, rather than remembering to manually run it.
>>
>
> scripts/clean-includ
On Sun, Oct 9, 2016 at 3:04 AM, Eric Blake wrote:
> On 10/08/2016 06:32 AM, Anand J wrote:
> > I have replied for the questions inline. Also I'll make changes to the
> > patch as per the review and send the updated one.
> >
> > Thanks,
> > Anand
> >
> > On Fri, Oct 7, 2016 at 8:01 PM, Eric Blake
On 10/08/2016 06:32 AM, Anand J wrote:
> I have replied for the questions inline. Also I'll make changes to the
> patch as per the review and send the updated one.
>
> Thanks,
> Anand
>
> On Fri, Oct 7, 2016 at 8:01 PM, Eric Blake wrote:
>
>> On 10/07/2016 03:46 AM, Anand J wrote:
>>> Some file
I have replied for the questions inline. Also I'll make changes to the
patch as per the review and send the updated one.
Thanks,
Anand
On Fri, Oct 7, 2016 at 8:01 PM, Eric Blake wrote:
> On 10/07/2016 03:46 AM, Anand J wrote:
> > Some files contain multiple #includes of the same header file.
>
On 7 October 2016 at 15:31, Eric Blake wrote:
> On 10/07/2016 03:46 AM, Anand J wrote:
>> +++ b/hw/pci-bridge/pci_expander_bridge.c
>> @@ -13,7 +13,6 @@
>> #include "qemu/osdep.h"
>> #include "qapi/error.h"
>> #include "hw/pci/pci.h"
>> -#include "hw/pci/pci_bus.h"
>> #include "hw/pci/pci_host
On 7 October 2016 at 09:46, Anand J wrote:
> Some files contain multiple #includes of the same header file.
> Removed most of those unnecessary duplicate entries.
>
> Signed-off-by: Anand J
> disas/libvixl/vixl/globals.h| 1 -
This is a third party file which we copy into our tree;
we p
On 10/07/2016 03:46 AM, Anand J wrote:
> Some files contain multiple #includes of the same header file.
> Removed most of those unnecessary duplicate entries.
How did you find these? Is it a repeatable formula for rerunning a year
from now to find new culprits? If so, listing it in the commit mes
Some files contain multiple #includes of the same header file.
Removed most of those unnecessary duplicate entries.
Signed-off-by: Anand J
---
accel.c | 1 -
cputlb.c| 1 -
disas/libvixl/vixl/globals.h| 1 -
gdbstub.c
