Re: [Qemu-devel] [PATCH] cirrus_vga: Remove unneeded reset

2011-03-28 Thread Stefan Weil
Am 28.03.2011 11:24, schrieb Isaku Yamahata: On Mon, Mar 28, 2011 at 11:21:23AM +0200, Markus Armbruster wrote: Isaku Yamahata writes: On Mon, Mar 28, 2011 at 07:18:04AM +0200, Stefan Weil wrote: Am 28.03.2011 04:17, schrieb Isaku Yamahata: [...] On Sat, Mar 26, 2011 at 10:53:09PM +0100, S

Re: [Qemu-devel] [PATCH] cirrus_vga: Remove unneeded reset

2011-03-28 Thread Michael S. Tsirkin
On Mon, Mar 28, 2011 at 06:20:15PM +0200, Stefan Weil wrote: > Am 28.03.2011 11:24, schrieb Isaku Yamahata: > >On Mon, Mar 28, 2011 at 11:21:23AM +0200, Markus Armbruster wrote: > >>Isaku Yamahata writes: > >> > >>>On Mon, Mar 28, 2011 at 07:18:04AM +0200, Stefan Weil wrote: > Am 28.03.2011 04

Re: [Qemu-devel] [PATCH] cirrus_vga: Remove unneeded reset

2011-03-28 Thread Isaku Yamahata
On Mon, Mar 28, 2011 at 11:21:23AM +0200, Markus Armbruster wrote: > Isaku Yamahata writes: > > > On Mon, Mar 28, 2011 at 07:18:04AM +0200, Stefan Weil wrote: > >> Am 28.03.2011 04:17, schrieb Isaku Yamahata: > [...] > >>> On Sat, Mar 26, 2011 at 10:53:09PM +0100, Stefan Weil wrote: > cirrus

Re: [Qemu-devel] [PATCH] cirrus_vga: Remove unneeded reset

2011-03-28 Thread Markus Armbruster
Isaku Yamahata writes: > On Mon, Mar 28, 2011 at 07:18:04AM +0200, Stefan Weil wrote: >> Am 28.03.2011 04:17, schrieb Isaku Yamahata: [...] >>> On Sat, Mar 26, 2011 at 10:53:09PM +0100, Stefan Weil wrote: cirrus_reset is also called by the pci framework, so there is no need to call it i

Re: [Qemu-devel] [PATCH] cirrus_vga: Remove unneeded reset

2011-03-27 Thread Isaku Yamahata
On Mon, Mar 28, 2011 at 07:18:04AM +0200, Stefan Weil wrote: > Am 28.03.2011 04:17, schrieb Isaku Yamahata: >> Hi. cirrus_init_common() is used by both isa and pci cirrus. >> and isa cirrus isn't qdevfied yet. >> So what you want is >> - remove qemu_register_reset() and cirrus_reset() from cirrus_i

Re: [Qemu-devel] [PATCH] cirrus_vga: Remove unneeded reset

2011-03-27 Thread Stefan Weil
Am 28.03.2011 04:17, schrieb Isaku Yamahata: Hi. cirrus_init_common() is used by both isa and pci cirrus. and isa cirrus isn't qdevfied yet. So what you want is - remove qemu_register_reset() and cirrus_reset() from cirrus_init_common() - add to PCIDeviceInfo cirrus_vga_info .qdev.reset = cir

Re: [Qemu-devel] [PATCH] cirrus_vga: Remove unneeded reset

2011-03-27 Thread Isaku Yamahata
Hi. cirrus_init_common() is used by both isa and pci cirrus. and isa cirrus isn't qdevfied yet. So what you want is - remove qemu_register_reset() and cirrus_reset() from cirrus_init_common() - add to PCIDeviceInfo cirrus_vga_info .qdev.reset = cirrus_reset() in order to use pci reset framewor

[Qemu-devel] [PATCH] cirrus_vga: Remove unneeded reset

2011-03-26 Thread Stefan Weil
cirrus_reset is also called by the pci framework, so there is no need to call it in cirrus_init_common. Cc: Michael S. Tsirkin Signed-off-by: Stefan Weil --- hw/cirrus_vga.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/cirrus_vga.c b/hw/cirrus_vga.c index 2724f7b.