Re: [Qemu-devel] [PATCH] chardev: fix mess in OPENED/CLOSED events when muxed

2018-11-04 Thread Marc-André Lureau
Hi On Mon, Nov 5, 2018 at 11:22 AM Artem Pisarenko wrote: > > Sorry, I forgot to check unit tests. Although, it's very strange that this > specific test failed while things work functionally... > > > I am a bit reluctant to take patches that don't actually "fix" things. > > > > Could you add some

Re: [Qemu-devel] [PATCH] chardev: fix mess in OPENED/CLOSED events when muxed

2018-11-04 Thread Artem Pisarenko
Sorry, I forgot to check unit tests. Although, it's very strange that this specific test failed while things work functionally... > I am a bit reluctant to take patches that don't actually "fix" things. > > Could you add some tests to demonstrate the problems? Ok >> @@ -257,6 +257,7 @@ void qemu

Re: [Qemu-devel] [PATCH] chardev: fix mess in OPENED/CLOSED events when muxed

2018-11-04 Thread Marc-André Lureau
Hi On Thu, Nov 1, 2018 at 6:55 PM Artem Pisarenko wrote: > > When chardev is multiplexed (mux=on) there are a lot of cases, when > CHR_EVENT_OPENED/CHR_EVENT_CLOSED events pairing (expected from > frontend side) is broken. There are either generation of multiple > repeated or extra CHR_EVENT_OPENE

Re: [Qemu-devel] [PATCH] chardev: fix mess in OPENED/CLOSED events when muxed

2018-11-02 Thread no-reply
Subject: [Qemu-devel] [PATCH] chardev: fix mess in OPENED/CLOSED events when muxed === TEST SCRIPT BEGIN === #!/bin/bash time make docker-test-quick@centos7 SHOW_ENV=1 J=8 === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' b83295ce

[Qemu-devel] [PATCH] chardev: fix mess in OPENED/CLOSED events when muxed

2018-11-01 Thread Artem Pisarenko
When chardev is multiplexed (mux=on) there are a lot of cases, when CHR_EVENT_OPENED/CHR_EVENT_CLOSED events pairing (expected from frontend side) is broken. There are either generation of multiple repeated or extra CHR_EVENT_OPENED events, or CHR_EVENT_CLOSED just isn't generated at all (when it d