Re: [Qemu-devel] [PATCH] chardev: Avoid adding duplicate chardev

2019-01-23 Thread Pankaj Gupta
> > On 1/22/19 8:41 AM, Pankaj Gupta wrote: > > Hotplugging existing char chardev with qmp, dereferences(removes) > > existing chardev. This patch avoids adding a chardev if a chardev > > with same id exists. > > > > > +++ b/chardev/char.c > > @@ -985,6 +985,12 @@ ChardevReturn *qmp_chardev_a

Re: [Qemu-devel] [PATCH] chardev: Avoid adding duplicate chardev

2019-01-22 Thread Eric Blake
On 1/22/19 8:41 AM, Pankaj Gupta wrote: > Hotplugging existing char chardev with qmp, dereferences(removes) > existing chardev. This patch avoids adding a chardev if a chardev > with same id exists. > > +++ b/chardev/char.c > @@ -985,6 +985,12 @@ ChardevReturn *qmp_chardev_add(const char *id,

[Qemu-devel] [PATCH] chardev: Avoid adding duplicate chardev

2019-01-22 Thread Pankaj Gupta
Hotplugging existing char chardev with qmp, dereferences(removes) existing chardev. This patch avoids adding a chardev if a chardev with same id exists. RH BZ 1660831: # (host) ls -lt /tmp/helloworld* srwxr-xr-x. /tmp/helloworld1 srwxr-xr-x. /tmp/helloworld2 Before this patch: hotplug exis