Re: [Qemu-devel] [PATCH] char: Enable build of pty on macOS

2018-08-22 Thread Paolo Bonzini
On 21/08/2018 20:29, Peter Maydell wrote: >> >> #if defined(__linux__) || defined(__sun__) || defined(__FreeBSD__) \ >> || defined(__NetBSD__) || defined(__OpenBSD__) || >> defined(__DragonFly__) \ >> -|| defined(__GLIBC__) >> +|| defined(__GLIBC__) || defined(__APPLE__) > We sh

Re: [Qemu-devel] [PATCH] char: Enable build of pty on macOS

2018-08-21 Thread Peter Maydell
On 21 August 2018 at 18:23, Roman Bolshakov wrote: > For some reason __APPLE__ was not checked in pty code. pty chardev > should be available on macOS, according to man page. > > Signed-off-by: Roman Bolshakov > --- > chardev/char-pty.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [Qemu-devel] [PATCH] char: Enable build of pty on macOS

2018-08-21 Thread Eric Blake
On 08/21/2018 12:23 PM, Roman Bolshakov wrote: For some reason __APPLE__ was not checked in pty code. pty chardev should be available on macOS, according to man page. Signed-off-by: Roman Bolshakov --- chardev/char-pty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cha

[Qemu-devel] [PATCH] char: Enable build of pty on macOS

2018-08-21 Thread Roman Bolshakov
For some reason __APPLE__ was not checked in pty code. pty chardev should be available on macOS, according to man page. Signed-off-by: Roman Bolshakov --- chardev/char-pty.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chardev/char-pty.c b/chardev/char-pty.c index 68fd4e20