Re: [Qemu-devel] [PATCH] build: preserve debug symbols with --enable-debug-info

2014-10-02 Thread Stefan Hajnoczi
On Thu, Sep 25, 2014 at 03:51:44PM +0200, Paolo Bonzini wrote: > The GNU Makefile standards have "make install" and "make > install-strip" targets. It would be nice to add "make install-strip" > and at the same time flip the default from --enable-strip to > --disable-strip. Makes sense. Stefan

Re: [Qemu-devel] [PATCH] build: preserve debug symbols with --enable-debug-info

2014-09-25 Thread Paolo Bonzini
Il 25/09/2014 12:49, Stefan Hajnoczi ha scritto: > On Thu, Sep 25, 2014 at 10:06:35AM +0200, Olaf Hering wrote: >> During code review for xen I noticed that --enable-debug-info >> would still strip the binaries because strip_opt= defaults to >> yes. If --enable-debug-info is passed to configure it

Re: [Qemu-devel] [PATCH] build: preserve debug symbols with --enable-debug-info

2014-09-25 Thread Michael Tokarev
25.09.2014 14:49, Stefan Hajnoczi wrote: [] > Perhaps package maintainers rely on installed binaries not having debug > symbols? Package maintainer can and _should_ watch for changes in new releases and update their packages to accomodate changes made upstream. > It's common to split the debug sy

Re: [Qemu-devel] [PATCH] build: preserve debug symbols with --enable-debug-info

2014-09-25 Thread Peter Maydell
On 25 September 2014 11:47, Olaf Hering wrote: > On Thu, Sep 25, Peter Maydell wrote: > So will --disable-strip remain for ever? Can I depend on that? We're not planning to remove it, certainly. We don't make strong guarantees about configure commandlines remaining stable across QEMU versions but

Re: [Qemu-devel] [PATCH] build: preserve debug symbols with --enable-debug-info

2014-09-25 Thread Olaf Hering
On Thu, Sep 25, Stefan Hajnoczi wrote: > If you make this change and packagers are unaware, they could > accidentally ship qemu packages that contain the full debug symbols in > the binaries. rpm will take care of that all by itself. Olaf

Re: [Qemu-devel] [PATCH] build: preserve debug symbols with --enable-debug-info

2014-09-25 Thread Stefan Hajnoczi
On Thu, Sep 25, 2014 at 10:06:35AM +0200, Olaf Hering wrote: > During code review for xen I noticed that --enable-debug-info would > still strip the binaries because strip_opt= defaults to yes. > If --enable-debug-info is passed to configure it has to be assumed > that not only the compiled binarie

Re: [Qemu-devel] [PATCH] build: preserve debug symbols with --enable-debug-info

2014-09-25 Thread Olaf Hering
On Thu, Sep 25, Peter Maydell wrote: > On 25 September 2014 09:06, Olaf Hering wrote: > > During code review for xen I noticed that --enable-debug-info would > > still strip the binaries because strip_opt= defaults to yes. > > If --enable-debug-info is passed to configure it has to be assumed > >

Re: [Qemu-devel] [PATCH] build: preserve debug symbols with --enable-debug-info

2014-09-25 Thread Peter Maydell
On 25 September 2014 09:06, Olaf Hering wrote: > During code review for xen I noticed that --enable-debug-info would > still strip the binaries because strip_opt= defaults to yes. > If --enable-debug-info is passed to configure it has to be assumed > that not only the compiled binaries have debugs

[Qemu-devel] [PATCH] build: preserve debug symbols with --enable-debug-info

2014-09-25 Thread Olaf Hering
During code review for xen I noticed that --enable-debug-info would still strip the binaries because strip_opt= defaults to yes. If --enable-debug-info is passed to configure it has to be assumed that not only the compiled binaries have debugsymbols, also the installed binaries should keep the symb