Re: [Qemu-devel] [PATCH] blockdev-backup: don't check aio_context too early

2019-05-09 Thread John Snow
On 5/9/19 4:00 AM, Kevin Wolf wrote: > Am 09.05.2019 um 00:55 hat John Snow geschrieben: >> >> On 5/7/19 4:50 AM, Kevin Wolf wrote: >>> Am 06.05.2019 um 22:33 hat John Snow geschrieben: in blockdev_backup_prepare, we check to make sure that the target is associated with a compatible ai

Re: [Qemu-devel] [PATCH] blockdev-backup: don't check aio_context too early

2019-05-09 Thread Kevin Wolf
Am 09.05.2019 um 00:55 hat John Snow geschrieben: > > On 5/7/19 4:50 AM, Kevin Wolf wrote: > > Am 06.05.2019 um 22:33 hat John Snow geschrieben: > >> in blockdev_backup_prepare, we check to make sure that the target is > >> associated with a compatible aio context. However, do_blockdev_backup is >

Re: [Qemu-devel] [PATCH] blockdev-backup: don't check aio_context too early

2019-05-08 Thread John Snow
On 5/7/19 4:50 AM, Kevin Wolf wrote: > Am 06.05.2019 um 22:33 hat John Snow geschrieben: >> in blockdev_backup_prepare, we check to make sure that the target is >> associated with a compatible aio context. However, do_blockdev_backup is >> called later and has some logic to move the target to a c

Re: [Qemu-devel] [PATCH] blockdev-backup: don't check aio_context too early

2019-05-07 Thread John Snow
On 5/7/19 4:50 AM, Kevin Wolf wrote: > Am 06.05.2019 um 22:33 hat John Snow geschrieben: >> in blockdev_backup_prepare, we check to make sure that the target is >> associated with a compatible aio context. However, do_blockdev_backup is >> called later and has some logic to move the target to a

Re: [Qemu-devel] [PATCH] blockdev-backup: don't check aio_context too early

2019-05-07 Thread Kevin Wolf
Am 06.05.2019 um 22:33 hat John Snow geschrieben: > in blockdev_backup_prepare, we check to make sure that the target is > associated with a compatible aio context. However, do_blockdev_backup is > called later and has some logic to move the target to a compatible > aio_context. The transaction ver

[Qemu-devel] [PATCH] blockdev-backup: don't check aio_context too early

2019-05-06 Thread John Snow
in blockdev_backup_prepare, we check to make sure that the target is associated with a compatible aio context. However, do_blockdev_backup is called later and has some logic to move the target to a compatible aio_context. The transaction version will fail certain commands needlessly early as a resu