Re: [Qemu-devel] [PATCH] blockdev: reset werror/rerror on drive_del

2013-06-05 Thread Fam Zheng
On Mon, 06/03 16:58, Stefan Hajnoczi wrote: > Paolo Bonzini suggested the following test case: > > 1. Launch a guest and wait at the GRUB boot menu: > > qemu-system-x86_64 -enable-kvm -m 1024 \ >-drive if=none,cache=none,file=test.img,id=foo,werror=stop,rerror=stop >-device virtio-blk-

Re: [Qemu-devel] [PATCH] blockdev: reset werror/rerror on drive_del

2013-06-05 Thread Stefan Hajnoczi
On Tue, Jun 04, 2013 at 06:37:27PM +0200, Markus Armbruster wrote: > Stefan Hajnoczi writes: > > > Paolo Bonzini suggested the following test case: > > > > 1. Launch a guest and wait at the GRUB boot menu: > > > > qemu-system-x86_64 -enable-kvm -m 1024 \ > >-drive if=none,cache=none,file=t

Re: [Qemu-devel] [PATCH] blockdev: reset werror/rerror on drive_del

2013-06-05 Thread Markus Armbruster
Eric Blake writes: > On 06/04/2013 01:24 PM, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >>> Il 04/06/2013 18:37, Markus Armbruster ha scritto: I figure the bit that can't be resolved now is letting the user switch off "stop on error" safely before a drive_del. Even if we ha

Re: [Qemu-devel] [PATCH] blockdev: reset werror/rerror on drive_del

2013-06-04 Thread Eric Blake
On 06/04/2013 01:24 PM, Markus Armbruster wrote: > Paolo Bonzini writes: > >> Il 04/06/2013 18:37, Markus Armbruster ha scritto: >>> I figure the bit that can't be resolved now is letting the user switch >>> off "stop on error" safely before a drive_del. Even if we had a command >>> for that, th

Re: [Qemu-devel] [PATCH] blockdev: reset werror/rerror on drive_del

2013-06-04 Thread Markus Armbruster
Paolo Bonzini writes: > Il 04/06/2013 18:37, Markus Armbruster ha scritto: >> I figure the bit that can't be resolved now is letting the user switch >> off "stop on error" safely before a drive_del. Even if we had a command >> for that, there'd still be a window between that command's execution

Re: [Qemu-devel] [PATCH] blockdev: reset werror/rerror on drive_del

2013-06-04 Thread Paolo Bonzini
Il 04/06/2013 18:37, Markus Armbruster ha scritto: > I figure the bit that can't be resolved now is letting the user switch > off "stop on error" safely before a drive_del. Even if we had a command > for that, there'd still be a window between that command's execution and > drive_del's. Your patc

Re: [Qemu-devel] [PATCH] blockdev: reset werror/rerror on drive_del

2013-06-04 Thread Markus Armbruster
Stefan Hajnoczi writes: > Paolo Bonzini suggested the following test case: > > 1. Launch a guest and wait at the GRUB boot menu: > > qemu-system-x86_64 -enable-kvm -m 1024 \ >-drive if=none,cache=none,file=test.img,id=foo,werror=stop,rerror=stop >-device virtio-blk-pci,drive=foo,id=vir

Re: [Qemu-devel] [PATCH] blockdev: reset werror/rerror on drive_del

2013-06-03 Thread Paolo Bonzini
Il 03/06/2013 16:58, Stefan Hajnoczi ha scritto: > Paolo Bonzini suggested the following test case: > > 1. Launch a guest and wait at the GRUB boot menu: > > qemu-system-x86_64 -enable-kvm -m 1024 \ >-drive if=none,cache=none,file=test.img,id=foo,werror=stop,rerror=stop >-device virtio

[Qemu-devel] [PATCH] blockdev: reset werror/rerror on drive_del

2013-06-03 Thread Stefan Hajnoczi
Paolo Bonzini suggested the following test case: 1. Launch a guest and wait at the GRUB boot menu: qemu-system-x86_64 -enable-kvm -m 1024 \ -drive if=none,cache=none,file=test.img,id=foo,werror=stop,rerror=stop -device virtio-blk-pci,drive=foo,id=virtio0,addr=4 2. Hot unplug the device: