Re: [Qemu-devel] [PATCH] block migration: Allow compile time disable

2017-05-15 Thread Eric Blake
On 05/15/2017 07:13 AM, Dr. David Alan Gilbert wrote: >>> +#ifndef CONFIG_LIVE_BLOCK_MIGRATION >>> +if (params.blk || params.shared) { >>> +error_setg(errp, "QEMU compiled without old-style block migration. >>> " >>> + "Use drive_mirror+NBD."); >> >> error_setg

Re: [Qemu-devel] [PATCH] block migration: Allow compile time disable

2017-05-15 Thread Dr. David Alan Gilbert
* Kashyap Chamarthy (kcham...@redhat.com) wrote: > On Wed, May 03, 2017 at 11:42:57AM +0100, Dr. David Alan Gilbert (git) wrote: > > A small comment inline, in the 'ifndef' section. > > > From: "Dr. David Alan Gilbert" > > > > Many users now prefer to use drive_mirror over NBD as an > > alterna

Re: [Qemu-devel] [PATCH] block migration: Allow compile time disable

2017-05-15 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> "Dr. David Alan Gilbert (git)" wrote: >> > From: "Dr. David Alan Gilbert" >> > >> > Many users now prefer to use drive_mirror over NBD as an >> > alternative to the older migrate -b option; drive_mirror is >> > mor

Re: [Qemu-devel] [PATCH] block migration: Allow compile time disable

2017-05-15 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" wrote: > > From: "Dr. David Alan Gilbert" > > > > Many users now prefer to use drive_mirror over NBD as an > > alternative to the older migrate -b option; drive_mirror is > > more complex to setup but gives you more opt

Re: [Qemu-devel] [PATCH] block migration: Allow compile time disable

2017-05-15 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 05/03/2017 05:42 AM, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Many users now prefer to use drive_mirror over NBD as an > > alternative to the older migrate -b option; drive_mirror is > > more complex to setup but g

Re: [Qemu-devel] [PATCH] block migration: Allow compile time disable

2017-05-04 Thread Eric Blake
On 05/03/2017 05:42 AM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Many users now prefer to use drive_mirror over NBD as an > alternative to the older migrate -b option; drive_mirror is > more complex to setup but gives you more options (e.g. only > migrating some of

Re: [Qemu-devel] [PATCH] block migration: Allow compile time disable

2017-05-04 Thread Kashyap Chamarthy
On Thu, May 04, 2017 at 11:25:25AM +0100, Dr. David Alan Gilbert wrote: > * Kashyap Chamarthy (kcham...@redhat.com) wrote: > > On Wed, May 03, 2017 at 11:42:57AM +0100, Dr. David Alan Gilbert (git) > > wrote: [...] > > > +#ifndef CONFIG_LIVE_BLOCK_MIGRATION > > > +if (params.blk || params.sh

Re: [Qemu-devel] [PATCH] block migration: Allow compile time disable

2017-05-04 Thread Dr. David Alan Gilbert
* Kashyap Chamarthy (kcham...@redhat.com) wrote: > On Wed, May 03, 2017 at 11:42:57AM +0100, Dr. David Alan Gilbert (git) wrote: > > A small comment inline, in the 'ifndef' section. > > > From: "Dr. David Alan Gilbert" > > > > Many users now prefer to use drive_mirror over NBD as an > > alterna

Re: [Qemu-devel] [PATCH] block migration: Allow compile time disable

2017-05-04 Thread Kashyap Chamarthy
On Wed, May 03, 2017 at 11:42:57AM +0100, Dr. David Alan Gilbert (git) wrote: A small comment inline, in the 'ifndef' section. > From: "Dr. David Alan Gilbert" > > Many users now prefer to use drive_mirror over NBD as an > alternative to the older migrate -b option; drive_mirror is > more compl

Re: [Qemu-devel] [PATCH] block migration: Allow compile time disable

2017-05-03 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Many users now prefer to use drive_mirror over NBD as an > alternative to the older migrate -b option; drive_mirror is > more complex to setup but gives you more options (e.g. only > migrating some of the disks if some of

[Qemu-devel] [PATCH] block migration: Allow compile time disable

2017-05-03 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Many users now prefer to use drive_mirror over NBD as an alternative to the older migrate -b option; drive_mirror is more complex to setup but gives you more options (e.g. only migrating some of the disks if some of them are shared). Allow the large chunk of block