Re: [Qemu-devel] [PATCH] block: vmdk - fixed sizeof() error

2015-02-12 Thread Stefan Hajnoczi
On Tue, Feb 10, 2015 at 01:22:56PM -0500, Jeff Cody wrote: > The size compared should be PATH_MAX, rather than sizeof(char *). > > Reported-by: Paolo Bonzini > Signed-off-by: Jeff Cody > --- > block/vmdk.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Thanks, applied to my block tr

Re: [Qemu-devel] [PATCH] block: vmdk - fixed sizeof() error

2015-02-10 Thread Max Reitz
On 2015-02-10 at 13:22, Jeff Cody wrote: The size compared should be PATH_MAX, rather than sizeof(char *). Reported-by: Paolo Bonzini Signed-off-by: Jeff Cody --- block/vmdk.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) I just noticed iotest 059 failing, bisected it and the ch

Re: [Qemu-devel] [PATCH] block: vmdk - fixed sizeof() error

2015-02-10 Thread Eric Blake
On 02/10/2015 11:22 AM, Jeff Cody wrote: > The size compared should be PATH_MAX, rather than sizeof(char *). > > Reported-by: Paolo Bonzini > Signed-off-by: Jeff Cody > --- > block/vmdk.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Eric Blake > > diff --git a/bloc

[Qemu-devel] [PATCH] block: vmdk - fixed sizeof() error

2015-02-10 Thread Jeff Cody
The size compared should be PATH_MAX, rather than sizeof(char *). Reported-by: Paolo Bonzini Signed-off-by: Jeff Cody --- block/vmdk.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 7d079ad..8410a15 100644 --- a/block/vmdk.c +++ b/block/v