Re: [Qemu-devel] [PATCH] block: reject O_RDWR open for read-only images

2010-04-23 Thread Christoph Hellwig
On Fri, Apr 23, 2010 at 06:09:09PM +0200, Kevin Wolf wrote: > Christoph, what about this one? It's still in the block branch, but I > have excluded it from first pull request round because these questions > are still open. > > What should I do with it? Drop it, wait for a new version or keep it as

Re: [Qemu-devel] [PATCH] block: reject O_RDWR open for read-only images

2010-04-23 Thread Kevin Wolf
Am 07.04.2010 14:32, schrieb Kevin Wolf: > Am 07.04.2010 13:57, schrieb Christoph Hellwig: >> Various obscure image format drivers do not allow write access. >> Instead of silently falling back to read-only access reject attempts >> to open these images for write access. >> >> Signed-off-by: Christ

Re: [Qemu-devel] [PATCH] block: reject O_RDWR open for read-only images

2010-04-08 Thread Kevin Wolf
Am 07.04.2010 17:02, schrieb Stefan Hajnoczi: > On Wed, Apr 7, 2010 at 12:57 PM, Christoph Hellwig wrote: >> Various obscure image format drivers do not allow write access. >> Instead of silently falling back to read-only access reject attempts >> to open these images for write access. > > Does b

Re: [Qemu-devel] [PATCH] block: reject O_RDWR open for read-only images

2010-04-07 Thread Stefan Hajnoczi
On Wed, Apr 7, 2010 at 12:57 PM, Christoph Hellwig wrote: > Various obscure image format drivers do not allow write access. > Instead of silently falling back to read-only access reject attempts > to open these images for write access. Does block/curl.c need this too? Stefan

Re: [Qemu-devel] [PATCH] block: reject O_RDWR open for read-only images

2010-04-07 Thread Kevin Wolf
Am 07.04.2010 13:57, schrieb Christoph Hellwig: > Various obscure image format drivers do not allow write access. > Instead of silently falling back to read-only access reject attempts > to open these images for write access. > > Signed-off-by: Christoph Hellwig I'm not sure about this patch. I

[Qemu-devel] [PATCH] block: reject O_RDWR open for read-only images

2010-04-07 Thread Christoph Hellwig
Various obscure image format drivers do not allow write access. Instead of silently falling back to read-only access reject attempts to open these images for write access. Signed-off-by: Christoph Hellwig Index: qemu/block/bochs.c =