Re: [Qemu-devel] [PATCH] block: handle filenames with colons better

2012-08-17 Thread Iustin Pop
On Fri, Aug 17, 2012 at 12:15:41PM +0200, Kevin Wolf wrote: > Am 17.08.2012 12:05, schrieb Iustin Pop: > > On Fri, Aug 17, 2012 at 09:56:35AM +0200, Kevin Wolf wrote: > >> Am 17.08.2012 09:15, schrieb Iustin Pop: > >>> On Thu, Aug 16, 2012 at 11:24:11PM +0400, Michael Tokarev wrote: > On 16.08

Re: [Qemu-devel] [PATCH] block: handle filenames with colons better

2012-08-17 Thread Kevin Wolf
Am 17.08.2012 12:05, schrieb Iustin Pop: > On Fri, Aug 17, 2012 at 09:56:35AM +0200, Kevin Wolf wrote: >> Am 17.08.2012 09:15, schrieb Iustin Pop: >>> On Thu, Aug 16, 2012 at 11:24:11PM +0400, Michael Tokarev wrote: On 16.08.2012 18:58, Iustin Pop wrote: > Commit 947995c (block: protect pa

Re: [Qemu-devel] [PATCH] block: handle filenames with colons better

2012-08-17 Thread Iustin Pop
On Fri, Aug 17, 2012 at 09:56:35AM +0200, Kevin Wolf wrote: > Am 17.08.2012 09:15, schrieb Iustin Pop: > > On Thu, Aug 16, 2012 at 11:24:11PM +0400, Michael Tokarev wrote: > >> On 16.08.2012 18:58, Iustin Pop wrote: > >>> Commit 947995c (block: protect path_has_protocol from filenames with > >>> co

Re: [Qemu-devel] [PATCH] block: handle filenames with colons better

2012-08-17 Thread Kevin Wolf
Am 17.08.2012 09:15, schrieb Iustin Pop: > On Thu, Aug 16, 2012 at 11:24:11PM +0400, Michael Tokarev wrote: >> On 16.08.2012 18:58, Iustin Pop wrote: >>> Commit 947995c (block: protect path_has_protocol from filenames with >>> colons) introduced a way to handle filenames with colons based on >>> wh

Re: [Qemu-devel] [PATCH] block: handle filenames with colons better

2012-08-17 Thread Iustin Pop
On Thu, Aug 16, 2012 at 11:24:11PM +0400, Michael Tokarev wrote: > On 16.08.2012 18:58, Iustin Pop wrote: > > Commit 947995c (block: protect path_has_protocol from filenames with > > colons) introduced a way to handle filenames with colons based on > > whether the path contains a slash or not. IMHO

Re: [Qemu-devel] [PATCH] block: handle filenames with colons better

2012-08-16 Thread Michael Tokarev
On 16.08.2012 18:58, Iustin Pop wrote: > Commit 947995c (block: protect path_has_protocol from filenames with > colons) introduced a way to handle filenames with colons based on > whether the path contains a slash or not. IMHO this is not optimal, > since we shouldn't rely on the contents of the pa

[Qemu-devel] [PATCH] block: handle filenames with colons better

2012-08-16 Thread Iustin Pop
Commit 947995c (block: protect path_has_protocol from filenames with colons) introduced a way to handle filenames with colons based on whether the path contains a slash or not. IMHO this is not optimal, since we shouldn't rely on the contents of the path but rather on whether the given path exists