Re: [Qemu-devel] [PATCH] block: fix the use of protocols in backing files

2010-11-04 Thread Anthony Liguori
On 11/04/2010 07:54 AM, Kevin Wolf wrote: Am 27.10.2010 20:19, schrieb Anthony Liguori: Signed-off-by: Anthony Liguori diff --git a/block.c b/block.c index 1a965b2..00b6f21 100644 --- a/block.c +++ b/block.c @@ -603,10 +603,16 @@ int bdrv_open(BlockDriverState *bs, const char *filename, in

Re: [Qemu-devel] [PATCH] block: fix the use of protocols in backing files

2010-11-04 Thread Kevin Wolf
Am 04.11.2010 14:14, schrieb Anthony Liguori: > On 11/04/2010 07:54 AM, Kevin Wolf wrote: >> Am 27.10.2010 20:19, schrieb Anthony Liguori: >> >>> Signed-off-by: Anthony Liguori >>> >>> diff --git a/block.c b/block.c >>> index 1a965b2..00b6f21 100644 >>> --- a/block.c >>> +++ b/block.c >>> @@ -6

Re: [Qemu-devel] [PATCH] block: fix the use of protocols in backing files

2010-11-04 Thread Kevin Wolf
Am 27.10.2010 20:19, schrieb Anthony Liguori: > Signed-off-by: Anthony Liguori > > diff --git a/block.c b/block.c > index 1a965b2..00b6f21 100644 > --- a/block.c > +++ b/block.c > @@ -603,10 +603,16 @@ int bdrv_open(BlockDriverState *bs, const char > *filename, int flags, > BlockDriver

Re: [Qemu-devel] [PATCH] block: fix the use of protocols in backing files

2010-10-28 Thread Anthony Liguori
On 10/28/2010 04:51 AM, Daniel P. Berrange wrote: The problem is that this wouldn't work in the general case. It's rather an exception that it makes sense for file: backing files with file: images. Consider this: # qemu-img create -o backing_file=nbd:foo:1234 /tmp/main.img Without this patch

Re: [Qemu-devel] [PATCH] block: fix the use of protocols in backing files

2010-10-28 Thread Daniel P. Berrange
On Thu, Oct 28, 2010 at 11:49:58AM +0200, Kevin Wolf wrote: > Am 28.10.2010 11:35, schrieb Daniel P. Berrange: > > On Thu, Oct 28, 2010 at 09:30:09AM +0100, Stefan Hajnoczi wrote: > >> On Wed, Oct 27, 2010 at 7:19 PM, Anthony Liguori > >> wrote: > >>> Signed-off-by: Anthony Liguori > >>> > >>> d

Re: [Qemu-devel] [PATCH] block: fix the use of protocols in backing files

2010-10-28 Thread Kevin Wolf
Am 28.10.2010 11:35, schrieb Daniel P. Berrange: > On Thu, Oct 28, 2010 at 09:30:09AM +0100, Stefan Hajnoczi wrote: >> On Wed, Oct 27, 2010 at 7:19 PM, Anthony Liguori wrote: >>> Signed-off-by: Anthony Liguori >>> >>> diff --git a/block.c b/block.c >>> index 1a965b2..00b6f21 100644 >>> --- a/bloc

Re: [Qemu-devel] [PATCH] block: fix the use of protocols in backing files

2010-10-28 Thread Stefan Hajnoczi
On Thu, Oct 28, 2010 at 10:35:02AM +0100, Daniel P. Berrange wrote: > On Thu, Oct 28, 2010 at 09:30:09AM +0100, Stefan Hajnoczi wrote: > > On Wed, Oct 27, 2010 at 7:19 PM, Anthony Liguori > > wrote: > > > Signed-off-by: Anthony Liguori > > > > > > diff --git a/block.c b/block.c > > > index 1a965

Re: [Qemu-devel] [PATCH] block: fix the use of protocols in backing files

2010-10-28 Thread Daniel P. Berrange
On Thu, Oct 28, 2010 at 09:30:09AM +0100, Stefan Hajnoczi wrote: > On Wed, Oct 27, 2010 at 7:19 PM, Anthony Liguori wrote: > > Signed-off-by: Anthony Liguori > > > > diff --git a/block.c b/block.c > > index 1a965b2..00b6f21 100644 > > --- a/block.c > > +++ b/block.c > > @@ -603,10 +603,16 @@ int

Re: [Qemu-devel] [PATCH] block: fix the use of protocols in backing files

2010-10-28 Thread Kevin Wolf
Am 28.10.2010 10:30, schrieb Stefan Hajnoczi: > On Wed, Oct 27, 2010 at 7:19 PM, Anthony Liguori wrote: >> Signed-off-by: Anthony Liguori >> >> diff --git a/block.c b/block.c >> index 1a965b2..00b6f21 100644 >> --- a/block.c >> +++ b/block.c >> @@ -603,10 +603,16 @@ int bdrv_open(BlockDriverState

Re: [Qemu-devel] [PATCH] block: fix the use of protocols in backing files

2010-10-28 Thread Stefan Hajnoczi
On Wed, Oct 27, 2010 at 7:19 PM, Anthony Liguori wrote: > Signed-off-by: Anthony Liguori > > diff --git a/block.c b/block.c > index 1a965b2..00b6f21 100644 > --- a/block.c > +++ b/block.c > @@ -603,10 +603,16 @@ int bdrv_open(BlockDriverState *bs, const char > *filename, int flags, >         Blo

[Qemu-devel] [PATCH] block: fix the use of protocols in backing files (v2)

2010-10-27 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- v1 -> v2 - Fix up CODING_STYLE of modified code diff --git a/block.c b/block.c index 1a965b2..029017e 100644 --- a/block.c +++ b/block.c @@ -603,10 +603,17 @@ int bdrv_open(BlockDriverState *bs, const char *filename, int flags, BlockDriver *back_drv =

Re: [Qemu-devel] [PATCH] block: fix the use of protocols in backing files

2010-10-27 Thread Anthony Liguori
On 10/27/2010 02:22 PM, malc wrote: On Wed, 27 Oct 2010, Anthony Liguori wrote: Signed-off-by: Anthony Liguori diff --git a/block.c b/block.c index 1a965b2..00b6f21 100644 --- a/block.c +++ b/block.c @@ -603,10 +603,16 @@ int bdrv_open(BlockDriverState *bs, const char *filename, int flags

Re: [Qemu-devel] [PATCH] block: fix the use of protocols in backing files

2010-10-27 Thread malc
On Wed, 27 Oct 2010, Anthony Liguori wrote: > Signed-off-by: Anthony Liguori > > diff --git a/block.c b/block.c > index 1a965b2..00b6f21 100644 > --- a/block.c > +++ b/block.c > @@ -603,10 +603,16 @@ int bdrv_open(BlockDriverState *bs, const char > *filename, int flags, > BlockDriver *

[Qemu-devel] [PATCH] block: fix the use of protocols in backing files

2010-10-27 Thread Anthony Liguori
Signed-off-by: Anthony Liguori diff --git a/block.c b/block.c index 1a965b2..00b6f21 100644 --- a/block.c +++ b/block.c @@ -603,10 +603,16 @@ int bdrv_open(BlockDriverState *bs, const char *filename, int flags, BlockDriver *back_drv = NULL; bs->backing_hd = bdrv_new(""); -