Re: [Qemu-devel] [PATCH] block: fix memory leak in early exit

2015-10-15 Thread Jeff Cody
On Thu, Oct 15, 2015 at 05:54:27PM +0200, Stefan Hajnoczi wrote: > The stream block job has two early exit code paths. They do not free > s->backing_file_str. > > Also, the early exits rely on the fact that the coroutine hasn't yielded > yet and was launched from the main thread. Therefore the c

Re: [Qemu-devel] [PATCH] block: fix memory leak in early exit

2015-10-15 Thread Fam Zheng
On Thu, 10/15 17:54, Stefan Hajnoczi wrote: > The stream block job has two early exit code paths. They do not free > s->backing_file_str. > > Also, the early exits rely on the fact that the coroutine hasn't yielded > yet and was launched from the main thread. Therefore the coroutine is > guarant

[Qemu-devel] [PATCH] block: fix memory leak in early exit

2015-10-15 Thread Stefan Hajnoczi
The stream block job has two early exit code paths. They do not free s->backing_file_str. Also, the early exits rely on the fact that the coroutine hasn't yielded yet and was launched from the main thread. Therefore the coroutine is guaranteed to be running in the main thread where block_job_com