Re: [Qemu-devel] [PATCH] block: change default of .has_zero_init to 0

2013-06-28 Thread Peter Lieven
On 28.06.2013 10:06, Kevin Wolf wrote: Am 27.06.2013 um 15:52 hat Peter Lieven geschrieben: .has_zero_init defaults to 1 for all formats and protocols. this is a dangerous default since this means that all new added drivers need to manually overwrite it to 0 if they do not ensure that a device

Re: [Qemu-devel] [PATCH] block: change default of .has_zero_init to 0

2013-06-28 Thread Peter Lieven
On 28.06.2013 12:09, Kevin Wolf wrote: Am 28.06.2013 um 10:25 hat Peter Lieven geschrieben: On 28.06.2013 10:20, Kevin Wolf wrote: Am 28.06.2013 um 10:16 hat Peter Lieven geschrieben: On 28.06.2013 10:06, Kevin Wolf wrote: Am 27.06.2013 um 15:52 hat Peter Lieven geschrieben: .has_zero_init d

Re: [Qemu-devel] [PATCH] block: change default of .has_zero_init to 0

2013-06-28 Thread Kevin Wolf
Am 28.06.2013 um 10:25 hat Peter Lieven geschrieben: > On 28.06.2013 10:20, Kevin Wolf wrote: > >Am 28.06.2013 um 10:16 hat Peter Lieven geschrieben: > >>On 28.06.2013 10:06, Kevin Wolf wrote: > >>>Am 27.06.2013 um 15:52 hat Peter Lieven geschrieben: > .has_zero_init defaults to 1 for all forma

Re: [Qemu-devel] [PATCH] block: change default of .has_zero_init to 0

2013-06-28 Thread Peter Lieven
On 28.06.2013 10:20, Kevin Wolf wrote: Am 28.06.2013 um 10:16 hat Peter Lieven geschrieben: On 28.06.2013 10:06, Kevin Wolf wrote: Am 27.06.2013 um 15:52 hat Peter Lieven geschrieben: .has_zero_init defaults to 1 for all formats and protocols. this is a dangerous default since this means that

Re: [Qemu-devel] [PATCH] block: change default of .has_zero_init to 0

2013-06-28 Thread Kevin Wolf
Am 28.06.2013 um 10:16 hat Peter Lieven geschrieben: > On 28.06.2013 10:06, Kevin Wolf wrote: > >Am 27.06.2013 um 15:52 hat Peter Lieven geschrieben: > >>.has_zero_init defaults to 1 for all formats and protocols. > >> > >>this is a dangerous default since this means that all > >>new added drivers

Re: [Qemu-devel] [PATCH] block: change default of .has_zero_init to 0

2013-06-28 Thread Peter Lieven
On 28.06.2013 10:06, Kevin Wolf wrote: Am 27.06.2013 um 15:52 hat Peter Lieven geschrieben: .has_zero_init defaults to 1 for all formats and protocols. this is a dangerous default since this means that all new added drivers need to manually overwrite it to 0 if they do not ensure that a device

Re: [Qemu-devel] [PATCH] block: change default of .has_zero_init to 0

2013-06-28 Thread Kevin Wolf
Am 27.06.2013 um 15:52 hat Peter Lieven geschrieben: > .has_zero_init defaults to 1 for all formats and protocols. > > this is a dangerous default since this means that all > new added drivers need to manually overwrite it to 0 if > they do not ensure that a device is zero initialized > after bdrv

Re: [Qemu-devel] [PATCH] block: change default of .has_zero_init to 0

2013-06-27 Thread Eric Blake
On 06/27/2013 07:52 AM, Peter Lieven wrote: > .has_zero_init defaults to 1 for all formats and protocols. > > this is a dangerous default since this means that all > new added drivers need to manually overwrite it to 0 if > they do not ensure that a device is zero initialized > after bdrv_create()

Re: [Qemu-devel] [PATCH] block: change default of .has_zero_init to 0

2013-06-27 Thread Richard W.M. Jones
On Thu, Jun 27, 2013 at 03:52:34PM +0200, Peter Lieven wrote: > +/* save default */ A minor thing, but s/save/safe/ :-) Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-p2v converts physical machines to virtual machines. Boot with a live CD or ove

[Qemu-devel] [PATCH] block: change default of .has_zero_init to 0

2013-06-27 Thread Peter Lieven
.has_zero_init defaults to 1 for all formats and protocols. this is a dangerous default since this means that all new added drivers need to manually overwrite it to 0 if they do not ensure that a device is zero initialized after bdrv_create(). if a driver needs to explicitly set this value to 1 i