Re: [Qemu-devel] [PATCH] block: change default for discard and write zeroes to INT_MAX

2015-02-02 Thread Denis V. Lunev
On 02/02/15 20:34, Paolo Bonzini wrote: On 02/02/2015 18:00, Denis V. Lunev wrote: You are absolutely correct for NBD case but I do not get the point about SIZE_MAX for gluster. There is no such definition in their git at git://github.com/gluster/glusterfs nor in public API headers in Ubuntu

Re: [Qemu-devel] [PATCH] block: change default for discard and write zeroes to INT_MAX

2015-02-02 Thread Paolo Bonzini
On 02/02/2015 18:00, Denis V. Lunev wrote: >> > You are absolutely correct for NBD case but I do not get the > point about SIZE_MAX for gluster. There is no such definition > in their git at git://github.com/gluster/glusterfs nor in > public API headers in Ubuntu :( SIZE_MAX is defined in stdint

Re: [Qemu-devel] [PATCH] block: change default for discard and write zeroes to INT_MAX

2015-02-02 Thread Denis V. Lunev
On 02/02/15 19:45, Kevin Wolf wrote: Am 02.02.2015 um 17:25 hat Denis V. Lunev geschrieben: On 02/02/15 19:13, Kevin Wolf wrote: Am 02.02.2015 um 15:48 hat Peter Lieven geschrieben: do not trim requests if the driver does not supply a limit through BlockLimits. For write zeroes we still keep a

Re: [Qemu-devel] [PATCH] block: change default for discard and write zeroes to INT_MAX

2015-02-02 Thread Kevin Wolf
Am 02.02.2015 um 17:25 hat Denis V. Lunev geschrieben: > On 02/02/15 19:13, Kevin Wolf wrote: > >Am 02.02.2015 um 15:48 hat Peter Lieven geschrieben: > >>do not trim requests if the driver does not supply a limit > >>through BlockLimits. For write zeroes we still keep a limit > >>for the unsupporte

Re: [Qemu-devel] [PATCH] block: change default for discard and write zeroes to INT_MAX

2015-02-02 Thread Denis V. Lunev
On 02/02/15 19:13, Kevin Wolf wrote: Am 02.02.2015 um 15:48 hat Peter Lieven geschrieben: do not trim requests if the driver does not supply a limit through BlockLimits. For write zeroes we still keep a limit for the unsupported path to avoid allocating a big bounce buffer. Suggested-by: Kevin

Re: [Qemu-devel] [PATCH] block: change default for discard and write zeroes to INT_MAX

2015-02-02 Thread Kevin Wolf
Am 02.02.2015 um 15:48 hat Peter Lieven geschrieben: > do not trim requests if the driver does not supply a limit > through BlockLimits. For write zeroes we still keep a limit > for the unsupported path to avoid allocating a big bounce buffer. > > Suggested-by: Kevin Wolf > Suggested-by: Denis V.

[Qemu-devel] [PATCH] block: change default for discard and write zeroes to INT_MAX

2015-02-02 Thread Peter Lieven
do not trim requests if the driver does not supply a limit through BlockLimits. For write zeroes we still keep a limit for the unsupported path to avoid allocating a big bounce buffer. Suggested-by: Kevin Wolf Suggested-by: Denis V. Lunev Signed-off-by: Peter Lieven --- block.c | 16 --