Re: [Qemu-devel] [PATCH] block: add drive_backup HMP command

2013-06-26 Thread Stefan Hajnoczi
On Tue, Jun 25, 2013 at 04:36:53PM +0200, Paolo Bonzini wrote: > Il 25/06/2013 16:06, Kevin Wolf ha scritto: > > Am 25.06.2013 um 15:49 hat Paolo Bonzini geschrieben: > >> Il 25/06/2013 15:26, Kevin Wolf ha scritto: > > +if (!full) { > > +error_setg(&errp, "-f is not yet impleme

Re: [Qemu-devel] [PATCH] block: add drive_backup HMP command

2013-06-25 Thread Ian Main
On Tue, Jun 25, 2013 at 04:36:53PM +0200, Paolo Bonzini wrote: > Il 25/06/2013 16:06, Kevin Wolf ha scritto: > > Am 25.06.2013 um 15:49 hat Paolo Bonzini geschrieben: > >> Il 25/06/2013 15:26, Kevin Wolf ha scritto: > > +if (!full) { > > +error_setg(&errp, "-f is not yet impleme

Re: [Qemu-devel] [PATCH] block: add drive_backup HMP command

2013-06-25 Thread Kevin Wolf
Am 25.06.2013 um 16:36 hat Paolo Bonzini geschrieben: > Il 25/06/2013 16:06, Kevin Wolf ha scritto: > > Am 25.06.2013 um 15:49 hat Paolo Bonzini geschrieben: > >> Il 25/06/2013 15:26, Kevin Wolf ha scritto: > > +if (!full) { > > +error_setg(&errp, "-f is not yet implemented"); >

Re: [Qemu-devel] [PATCH] block: add drive_backup HMP command

2013-06-25 Thread Paolo Bonzini
Il 25/06/2013 16:06, Kevin Wolf ha scritto: > Am 25.06.2013 um 15:49 hat Paolo Bonzini geschrieben: >> Il 25/06/2013 15:26, Kevin Wolf ha scritto: > +if (!full) { > +error_setg(&errp, "-f is not yet implemented"); > +hmp_handle_error(mon, &errp); > +retur

Re: [Qemu-devel] [PATCH] block: add drive_backup HMP command

2013-06-25 Thread Kevin Wolf
Am 25.06.2013 um 15:49 hat Paolo Bonzini geschrieben: > Il 25/06/2013 15:26, Kevin Wolf ha scritto: > >> > +if (!full) { > >> > +error_setg(&errp, "-f is not yet implemented"); > >> > +hmp_handle_error(mon, &errp); > >> > +return; > >> > +} > > Then why make it a val

Re: [Qemu-devel] [PATCH] block: add drive_backup HMP command

2013-06-25 Thread Paolo Bonzini
Il 25/06/2013 15:26, Kevin Wolf ha scritto: >> > +if (!full) { >> > +error_setg(&errp, "-f is not yet implemented"); >> > +hmp_handle_error(mon, &errp); >> > +return; >> > +} > Then why make it a valid option and confuse users in the help text by > describing options

Re: [Qemu-devel] [PATCH] block: add drive_backup HMP command

2013-06-25 Thread Kevin Wolf
Am 25.06.2013 um 14:23 hat Stefan Hajnoczi geschrieben: > Make "drive_backup" available on the HMP monitor: > > drive_backup [-n] [-f] device target [format] > > The -n flag requests QEMU to reuse the image found in new-image-file, > instead of recreating it from scratch. > > The -f flag reque

[Qemu-devel] [PATCH] block: add drive_backup HMP command

2013-06-25 Thread Stefan Hajnoczi
Make "drive_backup" available on the HMP monitor: drive_backup [-n] [-f] device target [format] The -n flag requests QEMU to reuse the image found in new-image-file, instead of recreating it from scratch. The -f flag requests QEMU to copy the whole disk, so that the result does not need a back