Re: [Qemu-devel] [PATCH] block: Unlink temporary file

2014-03-12 Thread Stefan Hajnoczi
On Sat, Feb 15, 2014 at 06:03:21PM +0100, Max Reitz wrote: > If the image file cannot be opened and was created as a temporary file, > it should be deleted; thus, in this case, we should jump to the > "unlink_and_fail" label and not just to "fail". > > Reported-by: Benoît Canet > Signed-off-by: M

Re: [Qemu-devel] [PATCH] block: Unlink temporary file

2014-02-17 Thread Stefan Hajnoczi
On Sat, Feb 15, 2014 at 06:03:21PM +0100, Max Reitz wrote: > If the image file cannot be opened and was created as a temporary file, > it should be deleted; thus, in this case, we should jump to the > "unlink_and_fail" label and not just to "fail". > > Reported-by: Benoît Canet > Signed-off-by: M

[Qemu-devel] [PATCH] block: Unlink temporary file

2014-02-15 Thread Max Reitz
If the image file cannot be opened and was created as a temporary file, it should be deleted; thus, in this case, we should jump to the "unlink_and_fail" label and not just to "fail". Reported-by: Benoît Canet Signed-off-by: Max Reitz --- This patch's context depends on my bdrv_open()/bdrv_file_