Re: [Qemu-devel] [PATCH] block: Silence Coverity in bdrv_drop_intermediate()

2019-03-15 Thread Markus Armbruster
Kevin Wolf writes: > Coverity doesn't like that the return value of bdrv_check_update_perm() > stays unused only in this place (CID 1399710). > > Even if checking local_err should be equivalent to checking ret < 0, > let's switch to using the return value to be more consistent (and in > case of a

Re: [Qemu-devel] [PATCH] block: Silence Coverity in bdrv_drop_intermediate()

2019-03-15 Thread Peter Maydell
On Fri, 15 Mar 2019 at 14:27, Kevin Wolf wrote: > > Coverity doesn't like that the return value of bdrv_check_update_perm() > stays unused only in this place (CID 1399710). > > Even if checking local_err should be equivalent to checking ret < 0, > let's switch to using the return value to be more

[Qemu-devel] [PATCH] block: Silence Coverity in bdrv_drop_intermediate()

2019-03-15 Thread Kevin Wolf
Coverity doesn't like that the return value of bdrv_check_update_perm() stays unused only in this place (CID 1399710). Even if checking local_err should be equivalent to checking ret < 0, let's switch to using the return value to be more consistent (and in case of a bug somewhere down the call cha