Re: [Qemu-devel] [PATCH] block: Remove redundant assertion

2013-08-28 Thread Kevin Wolf
Am 27.08.2013 um 18:07 hat Stefan Weil geschrieben: > Am 27.08.2013 17:56, schrieb Kevin Wolf: > > The failing condition is checked immediately before the assertion, so > > keeping the assertion is kind of redundant. > > Are you sure that it is not the check which is redundant? > Is file == NULL a

Re: [Qemu-devel] [PATCH] block: Remove redundant assertion

2013-08-27 Thread Stefan Weil
Am 27.08.2013 17:56, schrieb Kevin Wolf: > The failing condition is checked immediately before the assertion, so > keeping the assertion is kind of redundant. Are you sure that it is not the check which is redundant? Is file == NULL allowed in this 'else' branch? Regards, Stefan > > Signed-off-b

[Qemu-devel] [PATCH] block: Remove redundant assertion

2013-08-27 Thread Kevin Wolf
The failing condition is checked immediately before the assertion, so keeping the assertion is kind of redundant. Signed-off-by: Kevin Wolf --- block.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block.c b/block.c index a387c1a..26639e8 100644 --- a/block.c +++ b/block.c @@ -743,7 +743,6