Re: [Qemu-devel] [PATCH] block: Make 'replication_state' an enum

2017-04-23 Thread Michael Tokarev
17.03.2017 05:17, Fam Zheng wrote: > BDRVReplicationState.replication_state is a name with a bit of > duplication, plus it could be an enum like BDRVReplicationState.mode, > which is be more readable and also more straightforward in a debuuger. Applied to trivial (with comment fixup), thanks! /mj

Re: [Qemu-devel] [PATCH] block: Make 'replication_state' an enum

2017-03-21 Thread Eric Blake
On 03/16/2017 09:17 PM, Fam Zheng wrote: > BDRVReplicationState.replication_state is a name with a bit of > duplication, plus it could be an enum like BDRVReplicationState.mode, > which is be more readable and also more straightforward in a debuuger. With the followup commit message cleanups, Rev

Re: [Qemu-devel] [PATCH] block: Make 'replication_state' an enum

2017-03-16 Thread Fam Zheng
On Fri, 03/17 10:17, Fam Zheng wrote: > BDRVReplicationState.replication_state is a name with a bit of > duplication, plus it could be an enum like BDRVReplicationState.mode, > which is be more readable and also more straightforward in a debuuger. s/is be/is/ s/debuuger/debugger/ Can I blame the

[Qemu-devel] [PATCH] block: Make 'replication_state' an enum

2017-03-16 Thread Fam Zheng
BDRVReplicationState.replication_state is a name with a bit of duplication, plus it could be an enum like BDRVReplicationState.mode, which is be more readable and also more straightforward in a debuuger. Rename it, and improve the type while at it. Signed-off-by: Fam Zheng --- block/replication