Re: [Qemu-devel] [PATCH] block: Fix vpc initialization of the Dynamic Disk Header

2011-11-09 Thread Kevin Wolf
Am 09.11.2011 17:32, schrieb Charles Arnold: On 11/9/2011 at 08:58 AM, in message <4ebaa30d.1090...@redhat.com>, Kevin Wolf > wrote: >> >> Right, I'm not arguing that your change is wrong. What I'm asking for is >> just something like: >> >> -dyndisk_header->data_offset = be64_to_c

Re: [Qemu-devel] [PATCH] block: Fix vpc initialization of the Dynamic Disk Header

2011-11-09 Thread Andreas Färber
Am 09.11.2011 17:32, schrieb Charles Arnold: On 11/9/2011 at 08:58 AM, in message <4ebaa30d.1090...@redhat.com>, Kevin Wolf > wrote: >> >> Right, I'm not arguing that your change is wrong. What I'm asking for is >> just something like: >> >> -dyndisk_header->data_offset = be64_to_c

Re: [Qemu-devel] [PATCH] block: Fix vpc initialization of the Dynamic Disk Header

2011-11-09 Thread Charles Arnold
>>> On 11/9/2011 at 08:58 AM, in message <4ebaa30d.1090...@redhat.com>, Kevin >>> Wolf wrote: > > Right, I'm not arguing that your change is wrong. What I'm asking for is > just something like: > > -dyndisk_header->data_offset = be64_to_cpu(0x); > +/* Note: The spec is actually

Re: [Qemu-devel] [PATCH] block: Fix vpc initialization of the Dynamic Disk Header

2011-11-09 Thread Andreas Färber
Am 09.11.2011 16:42, schrieb Charles Arnold: On 11/9/2011 at 02:46 AM, in message <4eba4bec.5040...@redhat.com>, Kevin Wolf > wrote: >> Am 08.11.2011 20:25, schrieb Charles Arnold: >>> The Data Offset field in the Dynamic Disk Header is an 8 byte field. >>> Although the specification (

Re: [Qemu-devel] [PATCH] block: Fix vpc initialization of the Dynamic Disk Header

2011-11-09 Thread Kevin Wolf
Am 09.11.2011 16:42, schrieb Charles Arnold: On 11/9/2011 at 02:46 AM, in message <4eba4bec.5040...@redhat.com>, Kevin Wolf > wrote: >> Am 08.11.2011 20:25, schrieb Charles Arnold: >>> The Data Offset field in the Dynamic Disk Header is an 8 byte field. >>> Although the specification (

Re: [Qemu-devel] [PATCH] block: Fix vpc initialization of the Dynamic Disk Header

2011-11-09 Thread Charles Arnold
>>> On 11/9/2011 at 02:46 AM, in message <4eba4bec.5040...@redhat.com>, Kevin >>> Wolf wrote: > Am 08.11.2011 20:25, schrieb Charles Arnold: >> The Data Offset field in the Dynamic Disk Header is an 8 byte field. >> Although the specification (2006-10-11) gives an example of initializing >> only

Re: [Qemu-devel] [PATCH] block: Fix vpc initialization of the Dynamic Disk Header

2011-11-09 Thread Kevin Wolf
Am 08.11.2011 20:25, schrieb Charles Arnold: > The Data Offset field in the Dynamic Disk Header is an 8 byte field. > Although the specification (2006-10-11) gives an example of initializing > only the first 4 bytes, images generated by Microsoft on Windows initialize > all 8 bytes. > > Failure t

Re: [Qemu-devel] [PATCH] block: Fix vpc initialization of the Dynamic Disk Header

2011-11-08 Thread Andreas Färber
Am 08.11.2011 20:25, schrieb Charles Arnold: > The Data Offset field in the Dynamic Disk Header is an 8 byte field. > Although the specification (2006-10-11) gives an example of initializing > only the first 4 bytes, images generated by Microsoft on Windows initialize > all 8 bytes. > > Failure t

[Qemu-devel] [PATCH] block: Fix vpc initialization of the Dynamic Disk Header

2011-11-08 Thread Charles Arnold
The Data Offset field in the Dynamic Disk Header is an 8 byte field. Although the specification (2006-10-11) gives an example of initializing only the first 4 bytes, images generated by Microsoft on Windows initialize all 8 bytes. Failure to initialize all 8 bytes results in errors from utilities