Re: [Qemu-devel] [PATCH] block: Fix open flags with BDRV_O_SNAPSHOT

2014-05-09 Thread Stefan Hajnoczi
On Wed, May 07, 2014 at 10:24:21AM +0200, Kevin Wolf wrote: > Perhaps the monitor should be changed to avoid printing so many useless > control characters, then we'd hit the limit less often... > > Stefan, didn't you plan to do something like this? Or was it unrelated? I encountered this when wor

Re: [Qemu-devel] [PATCH] block: Fix open flags with BDRV_O_SNAPSHOT

2014-05-07 Thread Stefan Hajnoczi
On Tue, May 06, 2014 at 12:19:10PM +0200, Kevin Wolf wrote: > The immediately visible effect of this patch is that it fixes committing > a temporary snapshot to its backing file. Previously, it would fail with > a "permission denied" error because bdrv_inherited_flags() forced the > backing file to

Re: [Qemu-devel] [PATCH] block: Fix open flags with BDRV_O_SNAPSHOT

2014-05-07 Thread Kevin Wolf
Am 06.05.2014 um 23:03 hat Max Reitz geschrieben: > On 06.05.2014 13:10, Jan Kiszka wrote: > >On 2014-05-06 12:19, Kevin Wolf wrote: > >>The immediately visible effect of this patch is that it fixes committing > >>a temporary snapshot to its backing file. Previously, it would fail with > >>a "permi

Re: [Qemu-devel] [PATCH] block: Fix open flags with BDRV_O_SNAPSHOT

2014-05-06 Thread Max Reitz
On 06.05.2014 13:10, Jan Kiszka wrote: On 2014-05-06 12:19, Kevin Wolf wrote: The immediately visible effect of this patch is that it fixes committing a temporary snapshot to its backing file. Previously, it would fail with a "permission denied" error because bdrv_inherited_flags() forced the ba

Re: [Qemu-devel] [PATCH] block: Fix open flags with BDRV_O_SNAPSHOT

2014-05-06 Thread Max Reitz
On 06.05.2014 12:19, Kevin Wolf wrote: The immediately visible effect of this patch is that it fixes committing a temporary snapshot to its backing file. Previously, it would fail with a "permission denied" error because bdrv_inherited_flags() forced the backing file to be read-only, ignoring the

Re: [Qemu-devel] [PATCH] block: Fix open flags with BDRV_O_SNAPSHOT

2014-05-06 Thread Jan Kiszka
On 2014-05-06 12:19, Kevin Wolf wrote: > The immediately visible effect of this patch is that it fixes committing > a temporary snapshot to its backing file. Previously, it would fail with > a "permission denied" error because bdrv_inherited_flags() forced the > backing file to be read-only, ignori

[Qemu-devel] [PATCH] block: Fix open flags with BDRV_O_SNAPSHOT

2014-05-06 Thread Kevin Wolf
The immediately visible effect of this patch is that it fixes committing a temporary snapshot to its backing file. Previously, it would fail with a "permission denied" error because bdrv_inherited_flags() forced the backing file to be read-only, ignoring the r/w reopen of bdrv_commit(). The bigger