Re: [Qemu-devel] [PATCH] block: Don't copy backing file name on error

2013-10-28 Thread Kevin Wolf
Am 26.10.2013 um 15:44 hat Max Reitz geschrieben: > bdrv_open_backing_file() tries to copy the backing file name using > pstrcpy directly after calling bdrv_open() to open the backing file > without checking whether that was actually successful. If it was not, > ps->backing_hd->file will probably b

Re: [Qemu-devel] [PATCH] block: Don't copy backing file name on error

2013-10-28 Thread Benoît Canet
Le Saturday 26 Oct 2013 à 15:44:43 (+0200), Max Reitz a écrit : > bdrv_open_backing_file() tries to copy the backing file name using > pstrcpy directly after calling bdrv_open() to open the backing file > without checking whether that was actually successful. If it was not, > ps->backing_hd->file w

Re: [Qemu-devel] [PATCH] block: Don't copy backing file name on error

2013-10-27 Thread Amos Kong
On Sat, Oct 26, 2013 at 9:44 PM, Max Reitz wrote: > > bdrv_open_backing_file() tries to copy the backing file name using > pstrcpy directly after calling bdrv_open() to open the backing file > without checking whether that was actually successful. If it was not, > ps->backing_hd->file will probabl

[Qemu-devel] [PATCH] block: Don't copy backing file name on error

2013-10-26 Thread Max Reitz
bdrv_open_backing_file() tries to copy the backing file name using pstrcpy directly after calling bdrv_open() to open the backing file without checking whether that was actually successful. If it was not, ps->backing_hd->file will probably be NULL and qemu will crash. Fix this by moving pstrcpy af