Re: [Qemu-devel] [PATCH] block: Create proper size file for disk mirror

2013-01-25 Thread Kevin Wolf
Am 25.01.2013 19:13, schrieb Eric Blake: > On 01/25/2013 11:10 AM, Vishvananda Ishaya wrote: >> >> On Jan 25, 2013, at 1:18 AM, Kevin Wolf wrote: >> >>> Am 24.01.2013 19:00, schrieb Vishvananda Ishaya: The qmp monitor command to mirror a disk was passing -1 for size along with the disk's

Re: [Qemu-devel] [PATCH] block: Create proper size file for disk mirror

2013-01-25 Thread Eric Blake
On 01/25/2013 11:10 AM, Vishvananda Ishaya wrote: > > On Jan 25, 2013, at 1:18 AM, Kevin Wolf wrote: > >> Am 24.01.2013 19:00, schrieb Vishvananda Ishaya: >>> The qmp monitor command to mirror a disk was passing -1 for size >>> along with the disk's backing file. This size of the resulting disk

Re: [Qemu-devel] [PATCH] block: Create proper size file for disk mirror

2013-01-25 Thread Vishvananda Ishaya
On Jan 25, 2013, at 1:18 AM, Kevin Wolf wrote: > Am 24.01.2013 19:00, schrieb Vishvananda Ishaya: >> The qmp monitor command to mirror a disk was passing -1 for size >> along with the disk's backing file. This size of the resulting disk >> is the size of the backing file, which is incorrect if t

Re: [Qemu-devel] [PATCH] block: Create proper size file for disk mirror

2013-01-25 Thread Kevin Wolf
Am 24.01.2013 19:00, schrieb Vishvananda Ishaya: > The qmp monitor command to mirror a disk was passing -1 for size > along with the disk's backing file. This size of the resulting disk > is the size of the backing file, which is incorrect if the disk > has been resized. Therefore we should always

Re: [Qemu-devel] [PATCH] block: Create proper size file for disk mirror

2013-01-25 Thread Stefan Hajnoczi
On Thu, Jan 24, 2013 at 10:00:40AM -0800, Vishvananda Ishaya wrote: > The qmp monitor command to mirror a disk was passing -1 for size > along with the disk's backing file. This size of the resulting disk > is the size of the backing file, which is incorrect if the disk > has been resized. Therefor

[Qemu-devel] [PATCH] block: Create proper size file for disk mirror

2013-01-24 Thread Vishvananda Ishaya
The qmp monitor command to mirror a disk was passing -1 for size along with the disk's backing file. This size of the resulting disk is the size of the backing file, which is incorrect if the disk has been resized. Therefore we should always pass in the size of the current disk. Signed-off-by: Vis