Re: [Qemu-devel] [PATCH] block: Avoid bogus flags during mirroring

2016-06-13 Thread Eric Blake
On 06/11/2016 08:15 PM, Fam Zheng wrote: > On Sat, 06/11 19:18, Eric Blake wrote: >> Commit e253f4b8 converted mirroring from sector-based bdrv_aio_* >> to byte-based blk_aio_*, but failed to account for the subtle >> difference in signatures (the former takes a semi-redundant length, >> the latter

Re: [Qemu-devel] [PATCH] block: Avoid bogus flags during mirroring

2016-06-11 Thread Fam Zheng
On Sat, 06/11 19:18, Eric Blake wrote: > Commit e253f4b8 converted mirroring from sector-based bdrv_aio_* > to byte-based blk_aio_*, but failed to account for the subtle > difference in signatures (the former takes a semi-redundant length, > the latter takes a flags parameter). Since all of our fl

[Qemu-devel] [PATCH] block: Avoid bogus flags during mirroring

2016-06-11 Thread Eric Blake
Commit e253f4b8 converted mirroring from sector-based bdrv_aio_* to byte-based blk_aio_*, but failed to account for the subtle difference in signatures (the former takes a semi-redundant length, the latter takes a flags parameter). Since all of our flags are currently smaller in size than BDRV_SEC