Re: [Qemu-devel] [PATCH] block/vmdk: Report failures in vmdk_read_cid()

2017-07-28 Thread Kevin Wolf
Am 09.07.2017 um 19:06 hat Peter Maydell geschrieben: > The function vmdk_read_cid() can fail if the read on the underlying > block device fails, or if there's a format error in the VMDK file. > However its API doesn't provide a mechanism to report these errors, > and in some cases we were returnin

Re: [Qemu-devel] [PATCH] block/vmdk: Report failures in vmdk_read_cid()

2017-07-13 Thread Kevin Wolf
Am 10.07.2017 um 03:58 hat Fam Zheng geschrieben: > On Sun, 07/09 18:06, Peter Maydell wrote: > > The function vmdk_read_cid() can fail if the read on the underlying > > block device fails, or if there's a format error in the VMDK file. > > However its API doesn't provide a mechanism to report thes

Re: [Qemu-devel] [PATCH] block/vmdk: Report failures in vmdk_read_cid()

2017-07-09 Thread Fam Zheng
On Sun, 07/09 18:06, Peter Maydell wrote: > The function vmdk_read_cid() can fail if the read on the underlying > block device fails, or if there's a format error in the VMDK file. > However its API doesn't provide a mechanism to report these errors, > and in some cases we were returning a CID of 0

[Qemu-devel] [PATCH] block/vmdk: Report failures in vmdk_read_cid()

2017-07-09 Thread Peter Maydell
The function vmdk_read_cid() can fail if the read on the underlying block device fails, or if there's a format error in the VMDK file. However its API doesn't provide a mechanism to report these errors, and in some cases we were returning a CID of 0 and in some cases a CID of 0x, either of