Re: [Qemu-devel] [PATCH] block/vdi: Fix locking for parallel requests

2015-02-27 Thread Kevin Wolf
Am 27.02.2015 um 12:25 hat Stefan Hajnoczi geschrieben: > On Tue, Feb 17, 2015 at 04:33:39PM -0500, Max Reitz wrote: > > Concurrently modifying the bmap is not a good idea; this patch adds a > > lock for it. See https://bugs.launchpad.net/qemu/+bug/1422307 for what > > can go wrong without. > > >

Re: [Qemu-devel] [PATCH] block/vdi: Fix locking for parallel requests

2015-02-27 Thread Stefan Hajnoczi
On Tue, Feb 17, 2015 at 04:33:39PM -0500, Max Reitz wrote: > Concurrently modifying the bmap is not a good idea; this patch adds a > lock for it. See https://bugs.launchpad.net/qemu/+bug/1422307 for what > can go wrong without. > > Signed-off-by: Max Reitz > --- > block/vdi.c | 23 ++

Re: [Qemu-devel] [PATCH] block/vdi: Fix locking for parallel requests

2015-02-18 Thread Max Reitz
On 2015-02-18 at 02:52, Paolo Bonzini wrote: On 17/02/2015 22:33, Max Reitz wrote: Concurrently modifying the bmap is not a good idea; this patch adds a lock for it. See https://bugs.launchpad.net/qemu/+bug/1422307 for what can go wrong without. Signed-off-by: Max Reitz --- block/vdi.c | 23

Re: [Qemu-devel] [PATCH] block/vdi: Fix locking for parallel requests

2015-02-18 Thread Max Reitz
On 2015-02-18 at 07:39, Kevin Wolf wrote: Am 17.02.2015 um 22:33 hat Max Reitz geschrieben: Concurrently modifying the bmap is not a good idea; Why? I mean, the fact that this fixes something for you probably means that there really is some piece of local state that is invalidated by concurrent

Re: [Qemu-devel] [PATCH] block/vdi: Fix locking for parallel requests

2015-02-18 Thread Kevin Wolf
Am 17.02.2015 um 22:33 hat Max Reitz geschrieben: > Concurrently modifying the bmap is not a good idea; Why? I mean, the fact that this fixes something for you probably means that there really is some piece of local state that is invalidated by concurrent writes, but it's not obvious to me what it

Re: [Qemu-devel] [PATCH] block/vdi: Fix locking for parallel requests

2015-02-17 Thread Paolo Bonzini
On 17/02/2015 22:33, Max Reitz wrote: > Concurrently modifying the bmap is not a good idea; this patch adds a > lock for it. See https://bugs.launchpad.net/qemu/+bug/1422307 for what > can go wrong without. > > Signed-off-by: Max Reitz > --- > block/vdi.c | 23 --- > 1 file

Re: [Qemu-devel] [PATCH] block/vdi: Fix locking for parallel requests

2015-02-17 Thread Paolo Bonzini
Cc: qemu-stable On 17/02/2015 22:33, Max Reitz wrote: > Concurrently modifying the bmap is not a good idea; this patch adds a > lock for it. See https://bugs.launchpad.net/qemu/+bug/1422307 for what > can go wrong without. > > Signed-off-by: Max Reitz > --- > block/vdi.c | 23 +

Re: [Qemu-devel] [PATCH] block/vdi: Fix locking for parallel requests

2015-02-17 Thread Max Reitz
On 2015-02-17 at 16:49, Paolo Bonzini wrote: Cc: qemu-stable Right, I forgot that. Thanks! Max On 17/02/2015 22:33, Max Reitz wrote: Concurrently modifying the bmap is not a good idea; this patch adds a lock for it. See https://bugs.launchpad.net/qemu/+bug/1422307 for what can go wrong wit

[Qemu-devel] [PATCH] block/vdi: Fix locking for parallel requests

2015-02-17 Thread Max Reitz
Concurrently modifying the bmap is not a good idea; this patch adds a lock for it. See https://bugs.launchpad.net/qemu/+bug/1422307 for what can go wrong without. Signed-off-by: Max Reitz --- block/vdi.c | 23 --- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a