Re: [Qemu-devel] [PATCH] block/ssh: remove dead code

2015-09-16 Thread Michael Tokarev
14.09.2015 14:12, Paolo Bonzini wrote: > The "err" label cannot be reached with qp != NULL. Remove the free-ing > of qp and avoid future regressions by removing the initializer. Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH] block/ssh: remove dead code

2015-09-14 Thread Fam Zheng
On Mon, 09/14 13:12, Paolo Bonzini wrote: > The "err" label cannot be reached with qp != NULL. Remove the free-ing > of qp and avoid future regressions by removing the initializer. > > Signed-off-by: Paolo Bonzini > --- > block/ssh.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) >

Re: [Qemu-devel] [PATCH] block/ssh: remove dead code

2015-09-14 Thread Richard W.M. Jones
On Mon, Sep 14, 2015 at 01:12:34PM +0200, Paolo Bonzini wrote: > The "err" label cannot be reached with qp != NULL. Remove the free-ing > of qp and avoid future regressions by removing the initializer. > > Signed-off-by: Paolo Bonzini > --- > block/ssh.c | 5 + > 1 file changed, 1 insertion

[Qemu-devel] [PATCH] block/ssh: remove dead code

2015-09-14 Thread Paolo Bonzini
The "err" label cannot be reached with qp != NULL. Remove the free-ing of qp and avoid future regressions by removing the initializer. Signed-off-by: Paolo Bonzini --- block/ssh.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/block/ssh.c b/block/ssh.c index 8d06739..d3