Re: [Qemu-devel] [PATCH] block/nfs: use per-object vars and make it modular

2014-05-13 Thread Fam Zheng
On Tue, 05/13 15:35, Peter Lieven wrote: > On 13.05.2014 15:19, Fam Zheng wrote: > >On Tue, 05/13 15:04, Peter Lieven wrote: > >>On 11.05.2014 15:07, Michael Tokarev wrote: > >>>nfs block module uses libnfs and uses pkg-config to determine > >>>its build information. Somehow it used only --libs, n

Re: [Qemu-devel] [PATCH] block/nfs: use per-object vars and make it modular

2014-05-13 Thread Peter Lieven
On 13.05.2014 15:19, Fam Zheng wrote: On Tue, 05/13 15:04, Peter Lieven wrote: On 11.05.2014 15:07, Michael Tokarev wrote: nfs block module uses libnfs and uses pkg-config to determine its build information. Somehow it used only --libs, not --cflags, and added those libs into global $LIBS, ins

Re: [Qemu-devel] [PATCH] block/nfs: use per-object vars and make it modular

2014-05-13 Thread Fam Zheng
On Tue, 05/13 15:04, Peter Lieven wrote: > On 11.05.2014 15:07, Michael Tokarev wrote: > >nfs block module uses libnfs and uses pkg-config to determine > >its build information. Somehow it used only --libs, not --cflags, > >and added those libs into global $LIBS, instead of using per-object > >var

Re: [Qemu-devel] [PATCH] block/nfs: use per-object vars and make it modular

2014-05-13 Thread Peter Lieven
On 11.05.2014 15:07, Michael Tokarev wrote: nfs block module uses libnfs and uses pkg-config to determine its build information. Somehow it used only --libs, not --cflags, and added those libs into global $LIBS, instead of using per-object variable. the missing cflags stuff was due to a bug in

[Qemu-devel] [PATCH] block/nfs: use per-object vars and make it modular

2014-05-11 Thread Michael Tokarev
nfs block module uses libnfs and uses pkg-config to determine its build information. Somehow it used only --libs, not --cflags, and added those libs into global $LIBS, instead of using per-object variable. Use both --libs and --cflags, use them as per-object variable, and finally make block/nfs.o