Re: [Qemu-devel] [PATCH] block/iscsi: Restrict Linux-specific code

2019-02-20 Thread Paolo Bonzini
On 20/02/19 01:05, Philippe Mathieu-Daudé wrote: > Some Linux specific code is missing guards, leading to > build failure on OSX: > > $ sudo brew install libiscsi > $ ./configure && make > [...] > CC block/iscsi.o > qemu/block/iscsi.c:338:24: error: 'iscsi_aiocb_info' defined but

[Qemu-devel] [PATCH] block/iscsi: Restrict Linux-specific code

2019-02-19 Thread Philippe Mathieu-Daudé
Some Linux specific code is missing guards, leading to build failure on OSX: $ sudo brew install libiscsi $ ./configure && make [...] CC block/iscsi.o qemu/block/iscsi.c:338:24: error: 'iscsi_aiocb_info' defined but not used [-Werror=unused-const-variable=] static const AIOCBI