Re: [Qemu-devel] [PATCH] block/file-posix: ignore fail on unlock bytes

2019-03-28 Thread Vladimir Sementsov-Ogievskiy
27.03.2019 15:49, Vladimir Sementsov-Ogievskiy wrote: > bdrv_replace_child() calls bdrv_check_perm() with error_abort on > loosening permissions. However file-locking operations may fail even > in this case, for example on NFS. And this leads to Qemu crash. > > Let's ignore such errors, as we do a

Re: [Qemu-devel] [PATCH] block/file-posix: ignore fail on unlock bytes

2019-03-27 Thread Fam Zheng
On Wed, 03/27 15:49, Vladimir Sementsov-Ogievskiy wrote: > bdrv_replace_child() calls bdrv_check_perm() with error_abort on > loosening permissions. However file-locking operations may fail even > in this case, for example on NFS. And this leads to Qemu crash. > > Let's ignore such errors, as we d

Re: [Qemu-devel] [PATCH] block/file-posix: ignore fail on unlock bytes

2019-03-27 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190327124915.22265-1-vsement...@virtuozzo.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bas

[Qemu-devel] [PATCH] block/file-posix: ignore fail on unlock bytes

2019-03-27 Thread Vladimir Sementsov-Ogievskiy
bdrv_replace_child() calls bdrv_check_perm() with error_abort on loosening permissions. However file-locking operations may fail even in this case, for example on NFS. And this leads to Qemu crash. Let's ignore such errors, as we do already on permission update commit and abort. Signed-off-by: Vl