Re: [Qemu-devel] [PATCH] block/dmg: make it modular if using additional library

2015-03-11 Thread Stefan Hajnoczi
On Tue, Mar 10, 2015 at 10:06:04AM +0300, Michael Tokarev wrote: > block/dmg can use additional library (libbz2) to read > bzip2-compressed files. Make the block driver to be > a module if libbz2 support is requested, to avoid extra > library dependency by default. > > Signed-off-by: Michael Toka

Re: [Qemu-devel] [PATCH] block/dmg: make it modular if using additional library

2015-03-11 Thread Stefan Hajnoczi
On Tue, Mar 10, 2015 at 05:38:32PM +0300, Michael Tokarev wrote: > 10.03.2015 17:07, Kevin Wolf wrote: > > Am 10.03.2015 um 15:01 hat Michael Tokarev geschrieben: > [] > >> That might be useful if module loading will be modified a bit, > >> like by loadin modules on demand only. Something like thi

Re: [Qemu-devel] [PATCH] block/dmg: make it modular if using additional library

2015-03-10 Thread Michael Tokarev
10.03.2015 17:07, Kevin Wolf wrote: > Am 10.03.2015 um 15:01 hat Michael Tokarev geschrieben: [] >> That might be useful if module loading will be modified a bit, >> like by loadin modules on demand only. Something like this, >> search a "foo" block driver in the registered list, found -> >> use i

Re: [Qemu-devel] [PATCH] block/dmg: make it modular if using additional library

2015-03-10 Thread Kevin Wolf
Am 10.03.2015 um 14:24 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Am 10.03.2015 um 10:17 hat Fam Zheng geschrieben: > >> On Tue, 03/10 09:50, Kevin Wolf wrote: > >> > Am 10.03.2015 um 08:06 hat Michael Tokarev geschrieben: > >> > > block/dmg can use additional library (libbz2)

Re: [Qemu-devel] [PATCH] block/dmg: make it modular if using additional library

2015-03-10 Thread Michael Tokarev
10.03.2015 16:24, Markus Armbruster wrote: [] > For me, avoiding bothersome dependencies is a strong practical argument > for making a something a loadable module. Other benefits of loadable > modules presented so far seem pretty negligible to me. If you want > them, no objection from me, as long

Re: [Qemu-devel] [PATCH] block/dmg: make it modular if using additional library

2015-03-10 Thread Markus Armbruster
Kevin Wolf writes: > Am 10.03.2015 um 10:17 hat Fam Zheng geschrieben: >> On Tue, 03/10 09:50, Kevin Wolf wrote: >> > Am 10.03.2015 um 08:06 hat Michael Tokarev geschrieben: >> > > block/dmg can use additional library (libbz2) to read >> > > bzip2-compressed files. Make the block driver to be >>

Re: [Qemu-devel] [PATCH] block/dmg: make it modular if using additional library

2015-03-10 Thread Kevin Wolf
Am 10.03.2015 um 10:17 hat Fam Zheng geschrieben: > On Tue, 03/10 09:50, Kevin Wolf wrote: > > Am 10.03.2015 um 08:06 hat Michael Tokarev geschrieben: > > > block/dmg can use additional library (libbz2) to read > > > bzip2-compressed files. Make the block driver to be > > > a module if libbz2 supp

Re: [Qemu-devel] [PATCH] block/dmg: make it modular if using additional library

2015-03-10 Thread Fam Zheng
On Tue, 03/10 09:50, Kevin Wolf wrote: > Am 10.03.2015 um 08:06 hat Michael Tokarev geschrieben: > > block/dmg can use additional library (libbz2) to read > > bzip2-compressed files. Make the block driver to be > > a module if libbz2 support is requested, to avoid extra > > library dependency by d

Re: [Qemu-devel] [PATCH] block/dmg: make it modular if using additional library

2015-03-10 Thread Peter Wu
On Tue, Mar 10, 2015 at 10:06:04AM +0300, Michael Tokarev wrote: > block/dmg can use additional library (libbz2) to read > bzip2-compressed files. Make the block driver to be > a module if libbz2 support is requested, to avoid extra > library dependency by default. > > Signed-off-by: Michael Toka

Re: [Qemu-devel] [PATCH] block/dmg: make it modular if using additional library

2015-03-10 Thread Kevin Wolf
Am 10.03.2015 um 08:06 hat Michael Tokarev geschrieben: > block/dmg can use additional library (libbz2) to read > bzip2-compressed files. Make the block driver to be > a module if libbz2 support is requested, to avoid extra > library dependency by default. > > Signed-off-by: Michael Tokarev Fir

[Qemu-devel] [PATCH] block/dmg: make it modular if using additional library

2015-03-10 Thread Michael Tokarev
block/dmg can use additional library (libbz2) to read bzip2-compressed files. Make the block driver to be a module if libbz2 support is requested, to avoid extra library dependency by default. Signed-off-by: Michael Tokarev -- This might be questionable, to make the thing to be either module or