Re: [Qemu-devel] [PATCH] blkdebug: show an error for invalid event names

2014-09-22 Thread Kevin Wolf
Am 20.09.2014 um 10:55 hat Stefan Hajnoczi geschrieben: > It is easy to typo a blkdebug configuration and waste a lot of time > figuring out why no rules are matching. > > Push the Error** down into add_rule() so we can report an error when the > event name is invalid. > > Signed-off-by: Stefan H

Re: [Qemu-devel] [PATCH] blkdebug: show an error for invalid event names

2014-09-22 Thread Gonglei (Arei)
> From: Stefan Hajnoczi [mailto:stefa...@redhat.com] > Sent: Monday, September 22, 2014 6:28 PM > Subject: Re: [Qemu-devel] [PATCH] blkdebug: show an error for invalid event > names > > On Sat, Sep 20, 2014 at 09:32:35AM +, Gonglei (Arei) wrote: > > > @@ -3

Re: [Qemu-devel] [PATCH] blkdebug: show an error for invalid event names

2014-09-22 Thread Stefan Hajnoczi
On Sat, Sep 20, 2014 at 09:32:35AM +, Gonglei (Arei) wrote: > > @@ -315,10 +320,21 @@ static int read_config(BDRVBlkdebugState *s, const > > char *filename, > > > > d.s = s; > > d.action = ACTION_INJECT_ERROR; > > -qemu_opts_foreach(&inject_error_opts, add_rule, &d, 0); > > +

Re: [Qemu-devel] [PATCH] blkdebug: show an error for invalid event names

2014-09-20 Thread Gonglei (Arei)
> Subject: [Qemu-devel] [PATCH] blkdebug: show an error for invalid event names > > It is easy to typo a blkdebug configuration and waste a lot of time > figuring out why no rules are matching. > > Push the Error** down into add_rule() so we can report an error when the >

[Qemu-devel] [PATCH] blkdebug: show an error for invalid event names

2014-09-20 Thread Stefan Hajnoczi
It is easy to typo a blkdebug configuration and waste a lot of time figuring out why no rules are matching. Push the Error** down into add_rule() so we can report an error when the event name is invalid. Signed-off-by: Stefan Hajnoczi --- block/blkdebug.c | 22 +++--- 1 file cha