> > +static int pcspk_audio_init(ISABus *bus)
> > +{
> > +isa_create_simple (bus, TYPE_PC_SPEAKER);
> > +return 0;
>
> Previously we had soundhw_init() calling pcspk_audio_init() and ignore
> failures. Now since you use isa_create_simple() which calls
> qdev_init_nofail(), failure will dir
Hi Gerd,
On 1/18/19 1:22 PM, Gerd Hoffmann wrote:
> Get rid of the pcspk_state global, allow pc speaker
> be added using "-device isa-pcspk".
>
> Signed-off-by: Gerd Hoffmann
> ---
> hw/audio/pcspk.c | 35 +++
> 1 file changed, 15 insertions(+), 20 deletions(-)
>
Patchew URL: https://patchew.org/QEMU/20190118122210.505-1-kra...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190118122210.505-1-kra...@redhat.com
Type: series
Subject: [Qemu-devel] [PATCH] audio: fix pc speaker
Get rid of the pcspk_state global, allow pc speaker
be added using "-device isa-pcspk".
Signed-off-by: Gerd Hoffmann
---
hw/audio/pcspk.c | 35 +++
1 file changed, 15 insertions(+), 20 deletions(-)
diff --git a/hw/audio/pcspk.c b/hw/audio/pcspk.c
index 908696d483
