Re: [Qemu-devel] [PATCH] audio: Convert use of atoi to qemu_strtoi

On 03/19/2018 10:01 AM, nee wrote: On Mon, Mar 19, 2018 at 2:47 PM, Eric Blake wrote: On 03/16/2018 09:40 AM, Nia Alarie wrote: If qemu_strtoi indicates an error, return the default value. Would it be better to diagnose the error instead of silently returning a default value? Possibly

Re: [Qemu-devel] [PATCH] audio: Convert use of atoi to qemu_strtoi

On Mon, Mar 19, 2018 at 2:47 PM, Eric Blake wrote: > On 03/16/2018 09:40 AM, Nia Alarie wrote: >> >> If qemu_strtoi indicates an error, return the default value. > > > Would it be better to diagnose the error instead of silently returning a > default value? > >> >> Signed-off-by: Nia Alarie >> --

Re: [Qemu-devel] [PATCH] audio: Convert use of atoi to qemu_strtoi

On 03/16/2018 09:40 AM, Nia Alarie wrote: If qemu_strtoi indicates an error, return the default value. Would it be better to diagnose the error instead of silently returning a default value? Signed-off-by: Nia Alarie --- audio/audio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletion

[Qemu-devel] [PATCH] audio: Convert use of atoi to qemu_strtoi

If qemu_strtoi indicates an error, return the default value. Signed-off-by: Nia Alarie --- audio/audio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/audio/audio.c b/audio/audio.c index 6eccdb17ee..d6e91901aa 100644 --- a/audio/audio.c +++ b/audio/audio.c @@ -335,9 +335,