Re: [Qemu-devel] [PATCH] arm highbank: force ramsize to INT_MAX when loading

2012-03-09 Thread Alexander Graf
On 09.03.2012, at 20:03, Andreas Färber wrote: > Am 09.03.2012 19:22, schrieb Alexander Graf: >> >> On 09.03.2012, at 17:40, Mark Langsdorf wrote: >> >>> On 03/09/2012 10:13 AM, Peter Maydell wrote: On 9 March 2012 15:57, Mark Langsdorf wrote: > Since the ram_size field of arm_boot_in

Re: [Qemu-devel] [PATCH] arm highbank: force ramsize to INT_MAX when loading

2012-03-09 Thread Andreas Färber
Am 09.03.2012 19:22, schrieb Alexander Graf: > > On 09.03.2012, at 17:40, Mark Langsdorf wrote: > >> On 03/09/2012 10:13 AM, Peter Maydell wrote: >>> On 9 March 2012 15:57, Mark Langsdorf wrote: Since the ram_size field of arm_boot_info is only an int, don't set that field to more than

Re: [Qemu-devel] [PATCH] arm highbank: force ramsize to INT_MAX when loading

2012-03-09 Thread Alexander Graf
On 09.03.2012, at 17:40, Mark Langsdorf wrote: > On 03/09/2012 10:13 AM, Peter Maydell wrote: >> On 9 March 2012 15:57, Mark Langsdorf wrote: >>> Since the ram_size field of arm_boot_info is only an int, don't set >>> that field to more than INT_MAX. Signed vs unsigned comparison >>> overruns ar

Re: [Qemu-devel] [PATCH] arm highbank: force ramsize to INT_MAX when loading

2012-03-09 Thread Mark Langsdorf
On 03/09/2012 10:13 AM, Peter Maydell wrote: > On 9 March 2012 15:57, Mark Langsdorf wrote: >> Since the ram_size field of arm_boot_info is only an int, don't set >> that field to more than INT_MAX. Signed vs unsigned comparison >> overruns are possible otherwise. > > Can't we just make arm_boot_

Re: [Qemu-devel] [PATCH] arm highbank: force ramsize to INT_MAX when loading

2012-03-09 Thread Peter Maydell
On 9 March 2012 15:57, Mark Langsdorf wrote: > Since the ram_size field of arm_boot_info is only an int, don't set > that field to more than INT_MAX. Signed vs unsigned comparison > overruns are possible otherwise. Can't we just make arm_boot_info.ram_size a uint32_t (propagating through signedne

[Qemu-devel] [PATCH] arm highbank: force ramsize to INT_MAX when loading

2012-03-09 Thread Mark Langsdorf
Since the ram_size field of arm_boot_info is only an int, don't set that field to more than INT_MAX. Signed vs unsigned comparison overruns are possible otherwise. Signed-off-by: Mark Langsdorf --- hw/highbank.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/highban