Re: [Qemu-devel] [PATCH] arm eabi TLS

2008-01-28 Thread Felipe Contreras
On Dec 13, 2007 3:15 AM, Thayne Harbaugh <[EMAIL PROTECTED]> wrote: > > > On Thu, 2007-12-13 at 01:21 +, Paul Brook wrote: > > > - It would be good to limit the changes in the CPU emulation code to > > > handle the TLS. For example, on MIPS, the TLS register must not be > > > stored in the CPU

Re: [Qemu-devel] [PATCH] arm eabi TLS

2007-12-13 Thread Daniel Jacobowitz
On Thu, Dec 13, 2007 at 01:21:03AM +, Paul Brook wrote: > I disagree. The TLS register is part of the CPU state. On many machines > (including ARMv6 CPUs) it's an actual CPU register. I'm fairly sure the same > is true for recent MIPS revisions. That's correct, though I don't know if there i

Re: [Qemu-devel] [PATCH] arm eabi TLS

2007-12-13 Thread Fabrice Bellard
Paul Brook wrote: - It would be good to limit the changes in the CPU emulation code to handle the TLS. For example, on MIPS, the TLS register must not be stored in the CPU state. Same for ARM. I disagree. The TLS register is part of the CPU state. On many machines (including ARMv6 CPUs) it's a

Re: [Qemu-devel] [PATCH] arm eabi TLS

2007-12-12 Thread Thayne Harbaugh
On Thu, 2007-12-13 at 01:21 +, Paul Brook wrote: > > - It would be good to limit the changes in the CPU emulation code to > > handle the TLS. For example, on MIPS, the TLS register must not be > > stored in the CPU state. Same for ARM. > > I disagree. The TLS register is part of the CPU state

Re: [Qemu-devel] [PATCH] arm eabi TLS

2007-12-12 Thread Paul Brook
> - It would be good to limit the changes in the CPU emulation code to > handle the TLS. For example, on MIPS, the TLS register must not be > stored in the CPU state. Same for ARM. I disagree. The TLS register is part of the CPU state. On many machines (including ARMv6 CPUs) it's an actual CPU re

Re: [Qemu-devel] [PATCH] arm eabi TLS

2007-12-12 Thread Fabrice Bellard
Thayne Harbaugh wrote: > I believe Paul Brook did the original patch for arm eabi TLS. The patch > has bounced around for a bit but hasn't been applied. We've been using > this patch for a while and have tweaked it to be a bit more correct as > far as code organization. > > Please let me know wh

Re: [Qemu-devel] [PATCH] arm eabi TLS

2007-12-11 Thread Paul Brook
On Wednesday 12 December 2007, Thayne Harbaugh wrote: > I believe Paul Brook did the original patch for arm eabi TLS. The patch > has bounced around for a bit but hasn't been applied. We've been using > this patch for a while and have tweaked it to be a bit more correct as > far as code organizat

[Qemu-devel] [PATCH] arm eabi TLS

2007-12-11 Thread Thayne Harbaugh
I believe Paul Brook did the original patch for arm eabi TLS. The patch has bounced around for a bit but hasn't been applied. We've been using this patch for a while and have tweaked it to be a bit more correct as far as code organization. Please let me know what else should be improved for this