Re: [Qemu-devel] [PATCH] arm: vexpress: Clear sysctl cfgctrl start bit

2013-01-24 Thread Christoffer Dall
On Thu, Jan 24, 2013 at 6:17 AM, Peter Maydell wrote: > On 23 December 2012 16:34, Christoffer Dall > wrote: >> On Sun, Dec 23, 2012 at 6:01 AM, Peter Maydell >> wrote: >>> On 22 December 2012 19:03, Christoffer Dall >>> wrote: The start bit should only be set to indicate that a function

Re: [Qemu-devel] [PATCH] arm: vexpress: Clear sysctl cfgctrl start bit

2013-01-24 Thread Peter Maydell
On 24 January 2013 15:43, Christoffer Dall wrote: > On Thu, Jan 24, 2013 at 6:17 AM, Peter Maydell > wrote: >> OK, if you've compared with hardware I'm happy. >> >> Reviewed-by: Peter Maydell >> > Will you include this with other patches for upstream, or? Yes, I'll put it in my arm-devs.next t

Re: [Qemu-devel] [PATCH] arm: vexpress: Clear sysctl cfgctrl start bit

2013-01-24 Thread Peter Maydell
On 23 December 2012 16:34, Christoffer Dall wrote: > On Sun, Dec 23, 2012 at 6:01 AM, Peter Maydell > wrote: >> On 22 December 2012 19:03, Christoffer Dall >> wrote: >>> The start bit should only be set to indicate that a function call is >>> underway, right now. When done with function, clear

Re: [Qemu-devel] [PATCH] arm: vexpress: Clear sysctl cfgctrl start bit

2012-12-23 Thread Christoffer Dall
On Sun, Dec 23, 2012 at 6:01 AM, Peter Maydell wrote: > On 22 December 2012 19:03, Christoffer Dall > wrote: >> The start bit should only be set to indicate that a function call is >> underway, right now. When done with function, clear it. > > Looks plausible but I'd like a crosscheck that this

Re: [Qemu-devel] [PATCH] arm: vexpress: Clear sysctl cfgctrl start bit

2012-12-23 Thread Peter Maydell
On 22 December 2012 19:03, Christoffer Dall wrote: > The start bit should only be set to indicate that a function call is > underway, right now. When done with function, clear it. Looks plausible but I'd like a crosscheck that this is how the hardware really behaves. -- PMM

[Qemu-devel] [PATCH] arm: vexpress: Clear sysctl cfgctrl start bit

2012-12-22 Thread Christoffer Dall
The start bit should only be set to indicate that a function call is underway, right now. When done with function, clear it. Cc: Peter Maydell Signed-off-by: Christoffer Dall --- hw/arm_sysctl.c |1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm_sysctl.c b/hw/arm_sysctl.c index 58eb