Re: [Qemu-devel] [PATCH] arm: Clarify the logic of set_pc()

2019-01-31 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190129121817.7109-1-jus...@mail.ru/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] arm: Clarify the logic of set_pc() Type: series Message-id: 20190129121817.7109-1-jus

Re: [Qemu-devel] [PATCH] arm: Clarify the logic of set_pc()

2019-01-31 Thread Peter Maydell
On Tue, 29 Jan 2019 at 12:18, Julia Suvorova wrote: > > Until now, the set_pc logic was unclear, which raised questions about > whether it should be used directly, applying a value to PC or adding > additional checks, for example, set the Thumb bit in Arm cpu. Let's set > the set_pc logic for “Con

Re: [Qemu-devel] [PATCH] arm: Clarify the logic of set_pc()

2019-01-29 Thread Stefan Hajnoczi
On Tue, Jan 29, 2019 at 03:18:17PM +0300, Julia Suvorova wrote: > Until now, the set_pc logic was unclear, which raised questions about > whether it should be used directly, applying a value to PC or adding > additional checks, for example, set the Thumb bit in Arm cpu. Let's set > the set_pc logic

[Qemu-devel] [PATCH] arm: Clarify the logic of set_pc()

2019-01-29 Thread Julia Suvorova via Qemu-devel
Until now, the set_pc logic was unclear, which raised questions about whether it should be used directly, applying a value to PC or adding additional checks, for example, set the Thumb bit in Arm cpu. Let's set the set_pc logic for “Configure the PC, as was done in the ELF file” and implement synch