Re: [Qemu-devel] [PATCH] apic: fixup fallthrough to PIC

2013-02-26 Thread Mark Asselstine
On February 26, 2013 21:03:46 Jan Kiszka wrote: > On 2013-02-26 20:48, Mark Asselstine wrote: > > Commit 0e21e12bb311c4c1095d0269dc2ef81196ccb60a [Don't route PIC > > interrupts through the local APIC if the local APIC config says so.] > > missed a check to ensure the local APIC is enabled. Since i

Re: [Qemu-devel] [PATCH] apic: fixup fallthrough to PIC

2013-02-26 Thread Jan Kiszka
On 2013-02-26 20:48, Mark Asselstine wrote: > Commit 0e21e12bb311c4c1095d0269dc2ef81196ccb60a [Don't route PIC > interrupts through the local APIC if the local APIC config says so.] > missed a check to ensure the local APIC is enabled. Since if the local > APIC is disabled it doesn't matter what th

[Qemu-devel] [PATCH] apic: fixup fallthrough to PIC

2013-02-26 Thread Mark Asselstine
Commit 0e21e12bb311c4c1095d0269dc2ef81196ccb60a [Don't route PIC interrupts through the local APIC if the local APIC config says so.] missed a check to ensure the local APIC is enabled. Since if the local APIC is disabled it doesn't matter what the local APIC config says. If this check isn't done