Re: [Qemu-devel] [PATCH] ahci.c: mask unused flags when reading size PRDT DBC

2014-06-30 Thread Eric Blake
On 06/30/2014 06:09 AM, Alexander Graf wrote: > > On 29.06.14 20:21, reza.jel...@gmail.com wrote: >> This requires a custom ovmf image with sata controller for testing [0] >> >> [0]: http://reza.jelveh.me/assets/OVMF.fd.bz2 >> > > I guess this is supposed to be a cover letter? A few rules for cov

Re: [Qemu-devel] [PATCH] ahci.c: mask unused flags when reading size PRDT DBC

2014-06-30 Thread Alexander Graf
On 29.06.14 20:21, reza.jel...@gmail.com wrote: From: Reza Jelveh This is a hint that your git configuration isn't fully correct. If the email address git thinks you want to use is the same as the From: email address, it will not print this line. I suppose the problem is with the differenc

Re: [Qemu-devel] [PATCH] ahci.c: mask unused flags when reading size PRDT DBC

2014-06-30 Thread Alexander Graf
On 29.06.14 20:21, reza.jel...@gmail.com wrote: This requires a custom ovmf image with sata controller for testing [0] [0]: http://reza.jelveh.me/assets/OVMF.fd.bz2 I guess this is supposed to be a cover letter? A few rules for cover letters: 1) Cover letters only make sense for patch s

[Qemu-devel] [PATCH] ahci.c: mask unused flags when reading size PRDT DBC

2014-06-29 Thread reza . jelveh
This requires a custom ovmf image with sata controller for testing [0] [0]: http://reza.jelveh.me/assets/OVMF.fd.bz2

[Qemu-devel] [PATCH] ahci.c: mask unused flags when reading size PRDT DBC

2014-06-29 Thread reza . jelveh
From: Reza Jelveh The data byte count(DBC) read from the description information is defined for 21:00. 30:22 are reserved and 31 is the Interrupt on Completion (I) flag. Interrupt is not implemented in QEMU. tbl_entry_size is a signed integer and improperly reading the DBC leads to a negative of