Re: [Qemu-devel] [PATCH] ahci: fix sysbus support

2014-03-18 Thread Peter Maydell
On 10 February 2014 23:02, Rob Herring wrote: > From: Rob Herring > > Non-PCI AHCI support is broken due to assertion failures when trying > to convert AHCIState to a PCIDevice pointer as AHCIState can have > different container structs. Fix this by using the non-asserting object > cast and check

Re: [Qemu-devel] [PATCH] ahci: fix sysbus support

2014-03-18 Thread Paolo Bonzini
Il 11/02/2014 01:32, Peter Maydell ha scritto: > @@ -1311,7 +1312,7 @@ static const VMStateDescription vmstate_sysbus_ahci = { > .name = "sysbus-ahci", > .unmigratable = 1, /* Still buggy under I/O load */ > .fields = (VMStateField []) { > -VMSTATE_AHCI(ahci, AHCIPCIState),

Re: [Qemu-devel] [PATCH] ahci: fix sysbus support

2014-03-17 Thread Rob Herring
On Mon, Feb 10, 2014 at 6:32 PM, Peter Maydell wrote: > On 10 February 2014 23:02, Rob Herring wrote: >> From: Rob Herring >> >> Non-PCI AHCI support is broken due to assertion failures when trying >> to convert AHCIState to a PCIDevice pointer as AHCIState can have >> different container struct

Re: [Qemu-devel] [PATCH] ahci: fix sysbus support

2014-02-10 Thread Peter Maydell
On 10 February 2014 23:02, Rob Herring wrote: > From: Rob Herring > > Non-PCI AHCI support is broken due to assertion failures when trying > to convert AHCIState to a PCIDevice pointer as AHCIState can have > different container structs. Fix this by using the non-asserting object > cast and check

[Qemu-devel] [PATCH] ahci: fix sysbus support

2014-02-10 Thread Rob Herring
From: Rob Herring Non-PCI AHCI support is broken due to assertion failures when trying to convert AHCIState to a PCIDevice pointer as AHCIState can have different container structs. Fix this by using the non-asserting object cast and checking the returned pointer is not NULL. The AddressSpace po