Re: [Qemu-devel] [PATCH] add input-send-event command

2014-06-17 Thread Marcelo Tosatti
On Tue, Jun 17, 2014 at 05:59:53AM -0600, Eric Blake wrote: > On 06/16/2014 05:15 PM, Marcelo Tosatti wrote: > > > > Which allows specification of absolute/relative, > > up/down and console parameters. > > > > Suggested by Gerd Hoffman. > > > > --- > > Needs S-o-B. > > > qapi-schema.json |

Re: [Qemu-devel] [PATCH] add input-send-event command

2014-06-17 Thread Marcelo Tosatti
On Tue, Jun 17, 2014 at 05:54:35AM -0600, Eric Blake wrote: > On 06/17/2014 03:02 AM, Gerd Hoffmann wrote: > > On Mo, 2014-06-16 at 20:15 -0300, Marcelo Tosatti wrote: > >> Which allows specification of absolute/relative, > >> up/down and console parameters. > > > > Looks good overall, only minor

Re: [Qemu-devel] [PATCH] add input-send-event command

2014-06-17 Thread Eric Blake
On 06/16/2014 05:15 PM, Marcelo Tosatti wrote: > > Which allows specification of absolute/relative, > up/down and console parameters. > > Suggested by Gerd Hoffman. > > --- Needs S-o-B. > qapi-schema.json | 18 > qmp-commands.hx | 59 > +

Re: [Qemu-devel] [PATCH] add input-send-event command

2014-06-17 Thread Eric Blake
On 06/17/2014 03:02 AM, Gerd Hoffmann wrote: > On Mo, 2014-06-16 at 20:15 -0300, Marcelo Tosatti wrote: >> Which allows specification of absolute/relative, >> up/down and console parameters. > > Looks good overall, only minor nits. Will wait for acks from qmp guys > before picking into input bra

Re: [Qemu-devel] [PATCH] add input-send-event command

2014-06-17 Thread Gerd Hoffmann
On Mo, 2014-06-16 at 20:15 -0300, Marcelo Tosatti wrote: > Which allows specification of absolute/relative, > up/down and console parameters. Looks good overall, only minor nits. Will wait for acks from qmp guys before picking into input branch. > Suggested by Gerd Hoffman. Huh? Signed-off mi

[Qemu-devel] [PATCH] add input-send-event command

2014-06-16 Thread Marcelo Tosatti
Which allows specification of absolute/relative, up/down and console parameters. Suggested by Gerd Hoffman. --- qapi-schema.json | 18 qmp-commands.hx | 59 +++ ui/input.c | 31 3 fil