Re: [Qemu-devel] [PATCH] acpi_piix4: fix save/load of PIIX4PMState

2011-04-19 Thread Isaku Yamahata
On Tue, Apr 19, 2011 at 02:33:46PM +0200, Juan Quintela wrote: > Isaku Yamahata wrote: > >> shouldn't last one still be uint16_t? > > > > It results in an error by type_check_pointer. > > You are right. We are just lying. Will think about how to fix this > properly (basically move the whole thi

Re: [Qemu-devel] [PATCH] acpi_piix4: fix save/load of PIIX4PMState

2011-04-19 Thread Juan Quintela
Isaku Yamahata wrote: >> shouldn't last one still be uint16_t? > > It results in an error by type_check_pointer. You are right. We are just lying. Will think about how to fix this properly (basically move the whole thing to a uint8_t array, and work from there. >> I guess that on ich9, GPE bec

Re: [Qemu-devel] [PATCH] acpi_piix4: fix save/load of PIIX4PMState

2011-04-19 Thread Isaku Yamahata
On Mon, Apr 18, 2011 at 06:26:08PM +0200, Juan Quintela wrote: > Isaku Yamahata wrote: > > It's vmstate parameter was wrong. This patch fixes it. > > > > Reported-by: Avi Kivity > > Signed-off-by: Isaku Yamahata > > --- > > hw/acpi_piix4.c |3 +-- > > 1 files changed, 1 insertions(+), 2 del

Re: [Qemu-devel] [PATCH] acpi_piix4: fix save/load of PIIX4PMState

2011-04-18 Thread Juan Quintela
Isaku Yamahata wrote: > It's vmstate parameter was wrong. This patch fixes it. > > Reported-by: Avi Kivity > Signed-off-by: Isaku Yamahata > --- > hw/acpi_piix4.c |3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c > index 96f5222..3

[Qemu-devel] [PATCH] acpi_piix4: fix save/load of PIIX4PMState

2011-04-18 Thread Isaku Yamahata
It's vmstate parameter was wrong. This patch fixes it. Reported-by: Avi Kivity Signed-off-by: Isaku Yamahata --- hw/acpi_piix4.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c index 96f5222..3a8fece 100644 --- a/hw/acpi_piix4.c +++ b