On 05/28/2012 02:54 PM, Max Filippov wrote:
>>>
>>> Right. If the fix is going to be checked in then TeLeMan's original version
>>> with '|' is preferable for this reason.
>>
>> I disagree. Whatever we call cpu_get_phys_page_debug() has to either
>> mask out the low bits, or not (I prefer the latt
On Mon, May 28, 2012 at 1:34 PM, Avi Kivity wrote:
> On 05/24/2012 10:58 PM, Max Filippov wrote:
>> On Thu, May 24, 2012 at 6:26 PM, Avi Kivity wrote:
>>> On 05/24/2012 05:11 PM, Max Filippov wrote:
>
> Not in breakpoint_invalidate as the missing offset was compensated
> before your c
On 05/24/2012 10:58 PM, Max Filippov wrote:
> On Thu, May 24, 2012 at 6:26 PM, Avi Kivity wrote:
>> On 05/24/2012 05:11 PM, Max Filippov wrote:
Not in breakpoint_invalidate as the missing offset was compensated
before your commit (well, starting with c2f07f81a2 in fact).
>>>
>>> I'd
On Thu, May 24, 2012 at 6:26 PM, Avi Kivity wrote:
> On 05/24/2012 05:11 PM, Max Filippov wrote:
>>>
>>> Not in breakpoint_invalidate as the missing offset was compensated
>>> before your commit (well, starting with c2f07f81a2 in fact).
>>
>> I'd say that compensation that you mention
>>
>> ra
On 2012-05-24 11:29, Max Filippov wrote:
> On Thu, May 24, 2012 at 6:21 PM, Jan Kiszka wrote:
>> On 2012-05-24 11:11, Max Filippov wrote:
>>> On Thu, May 24, 2012 at 5:26 PM, Jan Kiszka wrote:
On 2012-05-24 09:42, Max Filippov wrote:
> On Thu, May 24, 2012 at 4:16 PM, Jan Kiszka
>
On Thu, May 24, 2012 at 6:21 PM, Jan Kiszka wrote:
> On 2012-05-24 11:11, Max Filippov wrote:
>> On Thu, May 24, 2012 at 5:26 PM, Jan Kiszka wrote:
>>> On 2012-05-24 09:42, Max Filippov wrote:
On Thu, May 24, 2012 at 4:16 PM, Jan Kiszka wrote:
> On 2012-05-24 09:08, Max Filippov wrote:
On 05/24/2012 05:11 PM, Max Filippov wrote:
>>
>> Not in breakpoint_invalidate as the missing offset was compensated
>> before your commit (well, starting with c2f07f81a2 in fact).
>
> I'd say that compensation that you mention
>
> ram_addr = (memory_region_get_ram_addr(section.mr)
>
On 2012-05-24 11:11, Max Filippov wrote:
> On Thu, May 24, 2012 at 5:26 PM, Jan Kiszka wrote:
>> On 2012-05-24 09:42, Max Filippov wrote:
>>> On Thu, May 24, 2012 at 4:16 PM, Jan Kiszka wrote:
On 2012-05-24 09:08, Max Filippov wrote:
> On Thu, May 24, 2012 at 3:25 PM, Jan Kiszka
>
On Thu, May 24, 2012 at 5:26 PM, Jan Kiszka wrote:
> On 2012-05-24 09:42, Max Filippov wrote:
>> On Thu, May 24, 2012 at 4:16 PM, Jan Kiszka wrote:
>>> On 2012-05-24 09:08, Max Filippov wrote:
On Thu, May 24, 2012 at 3:25 PM, Jan Kiszka wrote:
> On 2012-05-24 07:51, Max Filippov wrote:
On 2012-05-24 09:42, Max Filippov wrote:
> On Thu, May 24, 2012 at 4:16 PM, Jan Kiszka wrote:
>> On 2012-05-24 09:08, Max Filippov wrote:
>>> On Thu, May 24, 2012 at 3:25 PM, Jan Kiszka wrote:
On 2012-05-24 07:51, Max Filippov wrote:
> On Thu, May 24, 2012 at 6:34 AM, Jan Kiszka wrote:
On Thu, May 24, 2012 at 4:16 PM, Jan Kiszka wrote:
> On 2012-05-24 09:08, Max Filippov wrote:
>> On Thu, May 24, 2012 at 3:25 PM, Jan Kiszka wrote:
>>> On 2012-05-24 07:51, Max Filippov wrote:
On Thu, May 24, 2012 at 6:34 AM, Jan Kiszka wrote:
> From: Jan Kiszka
>
> tb_invalida
On 2012-05-24 09:08, Max Filippov wrote:
> On Thu, May 24, 2012 at 3:25 PM, Jan Kiszka wrote:
>> On 2012-05-24 07:51, Max Filippov wrote:
>>> On Thu, May 24, 2012 at 6:34 AM, Jan Kiszka wrote:
From: Jan Kiszka
tb_invalidate_phys_addr has to called with the exact physical address o
On Thu, May 24, 2012 at 3:25 PM, Jan Kiszka wrote:
> On 2012-05-24 07:51, Max Filippov wrote:
>> On Thu, May 24, 2012 at 6:34 AM, Jan Kiszka wrote:
>>> From: Jan Kiszka
>>>
>>> tb_invalidate_phys_addr has to called with the exact physical address of
>>> the breakpoint we add/remove, not just the
On 2012-05-24 07:51, Max Filippov wrote:
> On Thu, May 24, 2012 at 6:34 AM, Jan Kiszka wrote:
>> From: Jan Kiszka
>>
>> tb_invalidate_phys_addr has to called with the exact physical address of
>> the breakpoint we add/remove, not just the page's base address.
>> Otherwise we easily fail to flush
On Thu, May 24, 2012 at 6:34 AM, Jan Kiszka wrote:
> From: Jan Kiszka
>
> tb_invalidate_phys_addr has to called with the exact physical address of
> the breakpoint we add/remove, not just the page's base address.
> Otherwise we easily fail to flush the right TB.
>
> Regression of 1e7855a558.
Sor
On 2012-05-23 23:34, Jan Kiszka wrote:
> From: Jan Kiszka
>
> tb_invalidate_phys_addr has to called with the exact physical address of
> the breakpoint we add/remove, not just the page's base address.
> Otherwise we easily fail to flush the right TB.
>
> Regression of 1e7855a558.
Sorry, forgot
From: Jan Kiszka
tb_invalidate_phys_addr has to called with the exact physical address of
the breakpoint we add/remove, not just the page's base address.
Otherwise we easily fail to flush the right TB.
Regression of 1e7855a558.
Reported-by: TeLeMan
Signed-off-by: Jan Kiszka
---
exec.c |3
17 matches
Mail list logo
