Re: [Qemu-devel] [PATCH] TCG: Add preprocessor guards for optional tcg ops

2011-08-21 Thread Alexander Graf
On 11.08.2011, at 13:14, Richard Henderson wrote: > On 08/11/2011 09:38 AM, Blue Swirl wrote: >> On Thu, Aug 11, 2011 at 12:58 PM, Avi Kivity wrote: >>> On 08/11/2011 03:36 PM, Alexander Graf wrote: > > Or to have automatic generation of the optionals based on the > primitive

Re: [Qemu-devel] [PATCH] TCG: Add preprocessor guards for optional tcg ops

2011-08-11 Thread Richard Henderson
On 08/11/2011 09:38 AM, Blue Swirl wrote: > On Thu, Aug 11, 2011 at 12:58 PM, Avi Kivity wrote: >> On 08/11/2011 03:36 PM, Alexander Graf wrote: >>> Or to have automatic generation of the optionals based on the primitives, if the optionals are not present. >>> >>> That's what's hap

Re: [Qemu-devel] [PATCH] TCG: Add preprocessor guards for optional tcg ops

2011-08-11 Thread Blue Swirl
On Thu, Aug 11, 2011 at 12:58 PM, Avi Kivity wrote: > On 08/11/2011 03:36 PM, Alexander Graf wrote: >> >> > >> >  Or to have automatic generation of the optionals based on the >> > primitives, if the optionals are not present. >> >> That's what's happening in the background already, no? The line i

Re: [Qemu-devel] [PATCH] TCG: Add preprocessor guards for optional tcg ops

2011-08-11 Thread Avi Kivity
On 08/11/2011 03:36 PM, Alexander Graf wrote: > > Or to have automatic generation of the optionals based on the primitives, if the optionals are not present. That's what's happening in the background already, no? The line is towards tcg users though, not it tcg internal code. Yes, and it d

Re: [Qemu-devel] [PATCH] TCG: Add preprocessor guards for optional tcg ops

2011-08-11 Thread Alexander Graf
On 11.08.2011, at 14:28, Avi Kivity wrote: > On 08/11/2011 02:40 PM, Alexander Graf wrote: >> On 11.08.2011, at 13:24, malc wrote: >> >> > On Thu, 11 Aug 2011, Alexander Graf wrote: >> > >> >> While compiling current HEAD on a ppc64 box, I was confronted with the >> >> following compile error

Re: [Qemu-devel] [PATCH] TCG: Add preprocessor guards for optional tcg ops

2011-08-11 Thread Avi Kivity
On 08/11/2011 02:40 PM, Alexander Graf wrote: On 11.08.2011, at 13:24, malc wrote: > On Thu, 11 Aug 2011, Alexander Graf wrote: > >> While compiling current HEAD on a ppc64 box, I was confronted with the >> following compile errors: >> >> tcg/optimize.c: In function ?tcg_constant_folding?:

Re: [Qemu-devel] [PATCH] TCG: Add preprocessor guards for optional tcg ops

2011-08-11 Thread Alexander Graf
On 11.08.2011, at 13:24, malc wrote: > On Thu, 11 Aug 2011, Alexander Graf wrote: > >> While compiling current HEAD on a ppc64 box, I was confronted with the >> following compile errors: >> >> tcg/optimize.c: In function ?tcg_constant_folding?: >> tcg/optimize.c:546: error: ?INDEX_op_not_i32?

Re: [Qemu-devel] [PATCH] TCG: Add preprocessor guards for optional tcg ops

2011-08-11 Thread malc
On Thu, 11 Aug 2011, Alexander Graf wrote: > While compiling current HEAD on a ppc64 box, I was confronted with the > following compile errors: > > tcg/optimize.c: In function ?tcg_constant_folding?: > tcg/optimize.c:546: error: ?INDEX_op_not_i32? undeclared (first use in this > function) >

[Qemu-devel] [PATCH] TCG: Add preprocessor guards for optional tcg ops

2011-08-11 Thread Alexander Graf
While compiling current HEAD on a ppc64 box, I was confronted with the following compile errors: tcg/optimize.c: In function ‘tcg_constant_folding’: tcg/optimize.c:546: error: ‘INDEX_op_not_i32’ undeclared (first use in this function) tcg/optimize.c:546: error: (Each undeclared identifier i