Re: [Qemu-devel] [PATCH] Support virtio-scsi-pci adapter hot-plug

2012-05-25 Thread Stefan Hajnoczi
On Thu, May 24, 2012 at 7:31 AM, Kelvin Wang wrote: > On Wed, May 23, 2012 at 05:45:33PM +0300, Michael S. Tsirkin wrote: >> On Wed, May 23, 2012 at 04:30:06PM +0200, Paolo Bonzini wrote: >> > Il 23/05/2012 16:12, Michael S. Tsirkin ha scritto: >> > >> > 2, Run qemu with the option -monitor. >> >

Re: [Qemu-devel] [PATCH] Support virtio-scsi-pci adapter hot-plug

2012-05-24 Thread Kelvin Wang
On Thu, May 24, 2012 at 12:00:29PM +0200, Paolo Bonzini wrote: > Il 24/05/2012 08:31, Kelvin Wang ha scritto: > >> > > >> > If the point is to avoid need for manual bus rescans that's > >> > good. But please do not touch the legacy commands. > > So, may I sent another patch to "avoid need for manu

Re: [Qemu-devel] [PATCH] Support virtio-scsi-pci adapter hot-plug

2012-05-24 Thread Paolo Bonzini
Il 24/05/2012 08:31, Kelvin Wang ha scritto: >> > >> > If the point is to avoid need for manual bus rescans that's >> > good. But please do not touch the legacy commands. > So, may I sent another patch to "avoid need for manual bus rescans"? The virtio spec supports sending events for added and r

Re: [Qemu-devel] [PATCH] Support virtio-scsi-pci adapter hot-plug

2012-05-23 Thread Michael S. Tsirkin
On Thu, May 24, 2012 at 02:31:00PM +0800, Kelvin Wang wrote: > On Wed, May 23, 2012 at 05:45:33PM +0300, Michael S. Tsirkin wrote: > > On Wed, May 23, 2012 at 04:30:06PM +0200, Paolo Bonzini wrote: > > > Il 23/05/2012 16:12, Michael S. Tsirkin ha scritto: > > > >> > 2, Run qemu with the option -mon

Re: [Qemu-devel] [PATCH] Support virtio-scsi-pci adapter hot-plug

2012-05-23 Thread Kelvin Wang
On Wed, May 23, 2012 at 05:45:33PM +0300, Michael S. Tsirkin wrote: > On Wed, May 23, 2012 at 04:30:06PM +0200, Paolo Bonzini wrote: > > Il 23/05/2012 16:12, Michael S. Tsirkin ha scritto: > > >> > 2, Run qemu with the option -monitor. > > >> > > > >> > 3, In the guest, insert necessary modules: >

Re: [Qemu-devel] [PATCH] Support virtio-scsi-pci adapter hot-plug

2012-05-23 Thread Kelvin Wang
On Wed, May 23, 2012 at 05:12:16PM +0300, Michael S. Tsirkin wrote: > On Wed, May 23, 2012 at 09:52:06PM +0800, Kelvin Wang wrote: > > Support the virtio-scsi-pci adapter hot-plug. However, this patch can only > > make > > adapter hot-plugable. More effort is needed for LUN hot-plug. Actually, >

[Qemu-devel] [PATCH] Support virtio-scsi-pci adapter hot-plug

2012-05-23 Thread Kelvin Wang
Support the virtio-scsi-pci adapter hot-plug. However, this patch can only make adapter hot-plugable. More effort is needed for LUN hot-plug. Actually, that is the most valuable feature to virtio-scsi. Following the steps as follows can give an intuitive understanding of this feature after apply

Re: [Qemu-devel] [PATCH] Support virtio-scsi-pci adapter hot-plug

2012-05-23 Thread Michael S. Tsirkin
On Wed, May 23, 2012 at 04:30:06PM +0200, Paolo Bonzini wrote: > Il 23/05/2012 16:12, Michael S. Tsirkin ha scritto: > >> > 2, Run qemu with the option -monitor. > >> > > >> > 3, In the guest, insert necessary modules: > >> > for m in acpiphp pci_hotplug; do sudo modprobe ${m}; done > >> > > >> >

Re: [Qemu-devel] [PATCH] Support virtio-scsi-pci adapter hot-plug

2012-05-23 Thread Paolo Bonzini
Il 23/05/2012 16:12, Michael S. Tsirkin ha scritto: >> > 2, Run qemu with the option -monitor. >> > >> > 3, In the guest, insert necessary modules: >> > for m in acpiphp pci_hotplug; do sudo modprobe ${m}; done >> > >> > 4, In the qemu monitor,hot add a virtio-scsi-pci adapter: >> > (qemu)pci_add

Re: [Qemu-devel] [PATCH] Support virtio-scsi-pci adapter hot-plug

2012-05-23 Thread Michael S. Tsirkin
On Wed, May 23, 2012 at 09:52:06PM +0800, Kelvin Wang wrote: > Support the virtio-scsi-pci adapter hot-plug. However, this patch can only > make > adapter hot-plugable. More effort is needed for LUN hot-plug. Actually, that > is > the most valuable feature to virtio-scsi. > > Following the step