Re: [Qemu-devel] [PATCH] Split adb.c into adb.c, adb-mouse.c and adb-kbd.c

2017-12-20 Thread Laurent Vivier
Le 19/12/2017 à 20:33, Mark Cave-Ayland a écrit : > On 19/12/17 11:54, Laurent Vivier wrote: > >> It makes the code clearer to separate the bus implementation >> from the devices one. >> >> Remove ADB_DPRINTF() from adb.c instead of adding it to new files. >> Some minor changes to make checkpatch.

Re: [Qemu-devel] [PATCH] Split adb.c into adb.c, adb-mouse.c and adb-kbd.c

2017-12-19 Thread Mark Cave-Ayland
On 19/12/17 11:54, Laurent Vivier wrote: It makes the code clearer to separate the bus implementation from the devices one. Remove ADB_DPRINTF() from adb.c instead of adding it to new files. Some minor changes to make checkpatch.pl happy. Signed-off-by: Laurent Vivier --- hw/input/Makefile.

Re: [Qemu-devel] [PATCH] Split adb.c into adb.c, adb-mouse.c and adb-kbd.c

2017-12-19 Thread Laurent Vivier
Le 19/12/2017 à 16:26, Philippe Mathieu-Daudé a écrit : > Hi Laurent, > > On Tue, Dec 19, 2017 at 8:54 AM, Laurent Vivier wrote: >> It makes the code clearer to separate the bus implementation >> from the devices one. >> >> Remove ADB_DPRINTF() from adb.c instead of adding it to new files. >> Som

Re: [Qemu-devel] [PATCH] Split adb.c into adb.c, adb-mouse.c and adb-kbd.c

2017-12-19 Thread Philippe Mathieu-Daudé
Hi Laurent, On Tue, Dec 19, 2017 at 8:54 AM, Laurent Vivier wrote: > It makes the code clearer to separate the bus implementation > from the devices one. > > Remove ADB_DPRINTF() from adb.c instead of adding it to new files. > Some minor changes to make checkpatch.pl happy. > > Signed-off-by: Lau

[Qemu-devel] [PATCH] Split adb.c into adb.c, adb-mouse.c and adb-kbd.c

2017-12-19 Thread Laurent Vivier
It makes the code clearer to separate the bus implementation from the devices one. Remove ADB_DPRINTF() from adb.c instead of adding it to new files. Some minor changes to make checkpatch.pl happy. Signed-off-by: Laurent Vivier --- hw/input/Makefile.objs | 2 +- hw/input/adb-kbd.c | 395 +